Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #12

Closed
wants to merge 2 commits into from
Closed

update #12

wants to merge 2 commits into from

Conversation

kolchfa-aws
Copy link
Owner

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Version

List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Copy link

github-actions bot commented Jul 3, 2024

Thank you for submitting your PR. The PR states are Tech review -> Doc review -> Editorial review -> Merged.

PR checklist

  • Tech review:
    • If you're a developer submitting documentation for a feature you implemented, you can skip this step.
    • If you need help finding a tech reviewer, tag @kolchfa-aws.
  • Once the PR is ready for doc review, tag the assignee of this PR or @kolchfa-aws.
  • Doc review: A doc reviewer may:
    • Leave comments/suggestions: You will implement comments and add suggestions to batch and commit the batch as one commit.
    • Edit the PR: The doc reviewer will push edits to this PR directly (let us know if you don't want this option).
  • Editorial review: The doc reviewer will put the PR through editorial review.

Please be available to answer questions. Thank you!

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
@hdhalter
Copy link

hdhalter commented Jul 5, 2024

Thank you for submitting your PR. The PR states are: In progress (or Draft) → Tech review → Doc review → Editorial review → Merged. Select an option below when the content is ready for one of the review states.

PR checklist

  • Ready for tech review
    • If you're a developer submitting documentation for a feature you implemented, and it has been fully tested and validated, you can skip this step.
    • If you need help finding a tech reviewer, tag @kolchfa-aws.
  • Ready for doc review
    • The doc reviewer may push edits to the PR directly, or leave comments and editorial suggestions for you to approve, make changes, and commit yourself. (Let us know in a comment if you have a preference.)
    • If you need help finding a doc reviewer, tag the assignee of this PR or @kolchfa-aws.
  • Ready for editorial review
    • The doc reviewer will facilitate the editorial review. Following the editorial review, the doc reviewer may push edits to the PR directly or request that you respond to specific questions.

Please be available to answer questions. Thank you!

@hdhalter
Copy link

How about this:

Thank you for submitting your PR. The PR states are: In progress (or Draft) → Tech review → Doc review → Editorial review → Merged. Select an option below when the content is ready for review.

  • Ready for, or in tech review.
  • Ready for, or in doc review. The doc reviewer may push edits to the PR directly, or leave comments and editorial suggestions for you to approve, make changes, and commit yourself. (Let us know in a comment if you have a preference.)
  • Ready for, or in editorial review. The doc reviewer facilitates the editorial review when all doc review suggestions are complete. The doc reviewer may push editorial suggestions directly to the PR or request that the PR author respond to specific questions.

Please be available to answer questions. Thank you!

@kolchfa-aws kolchfa-aws marked this pull request as ready for review July 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants