Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Adjust the Order of Merged Comics #367

Open
7 tasks done
RejectVanity opened this issue Sep 17, 2024 · 11 comments
Open
7 tasks done

Unable to Adjust the Order of Merged Comics #367

RejectVanity opened this issue Sep 17, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@RejectVanity
Copy link

RejectVanity commented Sep 17, 2024

Steps to reproduce

  1. Merge any comic books,
  2. Adjust the order of merged comics in 'Merge settings'.
    Screenshot_2024-09-17-17-11-21-803_app komikku beta-edit

Expected behavior

The order of merged comics can be adjusted normally.

Actual behavior

Unable to adjust.

Crash logs

No response

Komikku version

1.11.3-9318

Android version

Android 14

Device

POCOF4 (munch)

Other details

When adjusting the order of comics, the chapters are rearranged as well. For example, the first and second chapters of comic "a" and the first and second chapters of comic "b" are originally ordered as a1, a2, b1, b2. After the order is adjusted, they become b1, b2, a1, a2.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • If this is an issue with an official extension, I should be opening an issue in the extensions repository.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 1.11.2.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@cuong-tran
Copy link
Collaborator

Did it ever work before?

@RejectVanity
Copy link
Author

RejectVanity commented Sep 21, 2024

Did it ever work before?

I just reverted to the 'Komikku-arm64-v8a-r9312.apk' version, and still can't adjust the order.

@cuong-tran
Copy link
Collaborator

There has never been any ability to adjust merged entries order yet. Why do you need to adjust order?

@cuong-tran cuong-tran added the enhancement New feature or request label Sep 23, 2024
@RejectVanity
Copy link
Author

There has never been any ability to adjust merged entries order yet. Why do you need to adjust order?

The symbol in front that looks like ‘=’ generally indicates that you can press and hold it to adjust the order.
I usually use the ‘merge’ function to combine serialized manga, either by parts (such as Part 1, Part 2) or by seasons (such as Season 1, Season 2).

@JoeloJoestar
Copy link

The order matters for the "Dedupe by priority" mode, and so it lets you set up the "priority". I just checked this and it is orderable only after selecting the "Dedupe by priority" mode and not the others. It is not very intuitive because there are no visual clues of this activating option, so this could be improved. The function though works, as in latest preview build.

@RejectVanity
Copy link
Author

RejectVanity commented Sep 23, 2024

There has never been any ability to adjust merged entries order yet. Why do you need to adjust order?

When adjusting the order of comics, the chapters are rearranged as well. For example, the first and second chapters of comic "a" and the first and second chapters of comic "b" are originally ordered as a1, a2, b1, b2. After the order is adjusted, they become b1, b2, a1, a2.

(I have added this information in the "Other details" section.)

@JoeloJoestar
Copy link

@RejectVanity please read my comment above if you did not and you find out it is working.

@RejectVanity
Copy link
Author

@RejectVanity please read my comment above if you did not and you find out it is working.

That is only to adjust the priority of removing duplicates, not to adjust the order of comics (in other words, chapters).

@JoeloJoestar
Copy link

@RejectVanity as I understand the Merge function has been designed to fuse sources together to fill the missing chapters void, and so it makes to have this option for deduplication, why would you want the same chapters of more sources stacked like you described instead of just having multiple entries?

@JoeloJoestar
Copy link

It's like doubling the number of chapters for a Manga.. Imagine to track this entry.. It's also against every sorting logic currently implemented.

@RejectVanity
Copy link
Author

It's like doubling the number of chapters for a Manga.. Imagine to track this entry.. It's also against every sorting logic currently implemented.

My idea is to merge the entire series into one book (e.g., Season 1, Season 2...), as some works are serialized in parts. I believe this should be considered a feature request, not a "bug" report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants