Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail resizing attemps on conflict error #384

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Do not fail resizing attemps on conflict error #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/ibm/ibmp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,9 @@ func (r IBMPowerDynamicConfig) resizeInstanceVolume(ctx context.Context, service
err = r.updateVolume(localCtx, service, instance.VolumeIDs[0])
if err != nil {
log.Error(err, "failed to resize power server volume")
return
if err.Error() != "conflict" { // conflicts may happen if volume is not ready yet
return
}
}
}
}()
Expand Down
Loading