Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #266

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci_master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
push:
branches:
- master
workflow_dispatch:

jobs:
ci:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci_pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: CI Pull Request

on:
pull_request:
workflow_dispatch:

jobs:
ci:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/code_check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
tool: 'pytest'
output-file-path: benchmark.json
save-data-file: ${{ inputs.store_benchmark }}
github-token: ${{ secrets.benchmark_token }}
github-token: ${{ secrets.GITHUB_TOKEN }}
auto-push: ${{ inputs.publish_performance }}
benchmark-data-dir-path: performance/${{ matrix.python-version }}
comment-always: false
Expand Down
2 changes: 2 additions & 0 deletions tests/test_types.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from dataclasses import InitVar
from sys import version_info
from typing import Optional, Union, List, Any, Dict, NewType, TypeVar, Generic, Collection, Tuple, Type
from unittest.mock import patch, Mock

Expand Down Expand Up @@ -401,6 +402,7 @@ class FakeType:
assert extract_generic(FakeType, defaults) == defaults


@pytest.mark.skipif(version_info < (3, 10), reason="writing union types as X | Y requires Python 3.10")
def test_optional_and_union_none_does_not_pollute_scope_via_caching():
is_generic(Optional[str])
is_generic_collection(str | None)