Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix the indentation #144

Open
HarikrishnanBalagopal opened this issue Oct 17, 2024 · 1 comment
Open

bug: fix the indentation #144

HarikrishnanBalagopal opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Hacktoberfest issues kind/bug Categorizes issue or PR as related to a bug.

Comments

@HarikrishnanBalagopal
Copy link
Contributor

HarikrishnanBalagopal commented Oct 17, 2024

The yaml is not being rendered properly. The indentation is messed up.

This issue is present on multiple tutorial pages.

Example

https://move2kube.konveyor.io/tutorials/customizing-the-output/custom-dockerfile-change-built-in-behavior

1. The `transformer.yaml` is the transformer configuration. We have [two changes](https://github.com/konveyor/move2kube/blob/main/assets/built-in/transformers/dockerfilegenerator/nodejs/transformer.yaml) here compared to the built-in transformer:
- The name of our custom transformer is `Nodejs-CustomFiles` (see `name` field in the `metadata` section).
- We are also specifying an `override` section which is asking Move2Kube to disable the transformer named `Nodejs-Dockerfile` if this transformer is present.
```console
$ cat customizations/custom-dockerfile-change-built-in-behavior/nodejs/transformer.yaml
```
```yaml
apiVersion: move2kube.konveyor.io/v1alpha1
kind: Transformer
metadata:
name: Nodejs-CustomFiles
labels:
move2kube.konveyor.io/task: containerization
move2kube.konveyor.io/built-in: false
spec:
class: "NodejsDockerfileGenerator"
directoryDetect:
levels: -1
consumes:
Service:
merge: false
produces:
Dockerfile:
disabled: false
DockerfileForService:
disabled: false
override:
matchLabels:
move2kube.konveyor.io/name: Nodejs-Dockerfile
```

Image

@HarikrishnanBalagopal HarikrishnanBalagopal added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Hacktoberfest issues kind/bug Categorizes issue or PR as related to a bug. labels Oct 17, 2024
@rachelcynthia
Copy link

Hi, can I be assigned to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest Hacktoberfest issues kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants