Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: nodeslo-controller enqueue request when node labels updated #2201

Merged

Conversation

chengjoey
Copy link
Contributor

@chengjoey chengjoey commented Sep 9, 2024

Ⅰ. Describe what this PR does

#2116
enqueue request when node update labels

Ⅲ. Describe how to verify it

running in local

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: joey <zchengjoey@gmail.com>
@chengjoey
Copy link
Contributor Author

cc @songtao98

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.73%. Comparing base (aacf585) to head (8e2a0e9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2201   +/-   ##
=======================================
  Coverage   67.72%   67.73%           
=======================================
  Files         446      446           
  Lines       42695    42695           
=======================================
+ Hits        28916    28919    +3     
+ Misses      11258    11257    -1     
+ Partials     2521     2519    -2     
Flag Coverage Δ
unittests 67.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@songtao98 songtao98 changed the title feat: nodeslo-controller enqueue request when node labels updated koord-descheduler: nodeslo-controller enqueue request when node labels updated Sep 9, 2024
@songtao98 songtao98 changed the title koord-descheduler: nodeslo-controller enqueue request when node labels updated koord-manager: nodeslo-controller enqueue request when node labels updated Sep 9, 2024
@songtao98
Copy link
Contributor

Good job! Thanks :)
/lgtm

@songtao98
Copy link
Contributor

cc @zwzhang0107

@songtao98 songtao98 added the lgtm label Sep 10, 2024
@zwzhang0107
Copy link
Contributor

/approve

@koordinator-bot koordinator-bot bot merged commit f959cdb into koordinator-sh:main Sep 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants