Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: support pod preemption from numa awareless reservation #2204

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

ZiMengSheng
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.69%. Comparing base (36cb609) to head (0395fb9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/plugins/nodenumaresource/preempt.go 28.57% 5 Missing ⚠️
...duler/plugins/nodenumaresource/resource_manager.go 20.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2204      +/-   ##
==========================================
- Coverage   67.70%   67.69%   -0.02%     
==========================================
  Files         446      446              
  Lines       42695    42715      +20     
==========================================
+ Hits        28908    28915       +7     
- Misses      11266    11275       +9     
- Partials     2521     2525       +4     
Flag Coverage Δ
unittests 67.69% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…tedCPUSet

Signed-off-by: wangjianyu.wjy <wangjianyu.wjy@alibaba-inc.com>
@saintube
Copy link
Member

/lgtm

@saintube saintube added the lgtm label Sep 18, 2024
@ZiMengSheng
Copy link
Contributor Author

/approve

@koordinator-bot koordinator-bot bot merged commit cd6ce25 into koordinator-sh:main Sep 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants