Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: optimize performance on transformer extension and Skip status #2211

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

saintube
Copy link
Member

@saintube saintube commented Sep 20, 2024

Ⅰ. Describe what this PR does

Improve scheduler performance by several small changes.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

…nts and using Skip status

Signed-off-by: saintube <saintube@foxmail.com>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.72%. Comparing base (c6cddf3) to head (c9f28f3).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scheduler/frameworkext/framework_extender.go 91.42% 2 Missing and 1 partial ⚠️
pkg/scheduler/plugins/elasticquota/plugin.go 0.00% 1 Missing ⚠️
pkg/scheduler/plugins/reservation/scoring.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2211      +/-   ##
==========================================
+ Coverage   67.70%   67.72%   +0.01%     
==========================================
  Files         446      446              
  Lines       42719    42739      +20     
==========================================
+ Hits        28925    28946      +21     
- Misses      11271    11272       +1     
+ Partials     2523     2521       -2     
Flag Coverage Δ
unittests 67.72% <87.80%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZiMengSheng
Copy link
Contributor

/lgtm

@saintube saintube added the lgtm label Sep 23, 2024
@hormes
Copy link
Member

hormes commented Sep 26, 2024

/approve

@koordinator-bot koordinator-bot bot merged commit 0fec022 into koordinator-sh:main Sep 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants