Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-resume reconnect handling #28

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

freyacodes
Copy link
Contributor

@freyacodes freyacodes commented Oct 5, 2023

  • Automatically reconnect on abnormal close frame
  • Cache voice server state in AbstractLink

The player is not currently restored upon reconnect. I plan to contribute that soon.

@freyacodes freyacodes marked this pull request as ready for review October 5, 2023 12:49
Copy link
Member

@DRSchlaubi DRSchlaubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, however, I can't take a loot at this properly until at saturday probabbly

.gitignore Outdated Show resolved Hide resolved
@freyacodes freyacodes mentioned this pull request Oct 10, 2023
@DRSchlaubi DRSchlaubi merged commit 21b6e13 into kordlib:main Oct 12, 2023
2 checks passed
@freyacodes freyacodes deleted the improved-reconnecting branch October 12, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants