Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a kobov5 target #1943

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Add a kobov5 target #1943

merged 6 commits into from
Oct 1, 2024

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 28, 2024

Now that the TCs are ready ;).

Also, minor third-party bumps.

(Rebase me)


This change is Reviewable

(Fix an unused function warning)
Use the future-proof USB PIDs for the latest Tolino/Kobo devices.
Should somewhat bias towards MTK SoCs, without entirely jumping to the
A53 (because both feature in-order pipelines).
kobov4 exists just because the TC exists, but we won't actually ship
binaries for it.

On the other hand, since kobov5 implies packaging changes, we *will*
make use of its greatly updated userland.
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really the place but potentially worth noting that there's a new https://github.com/fribidi/fribidi/releases/tag/v1.0.16 and https://github.com/harfbuzz/harfbuzz/releases/tag/10.0.1

(I'm too tired atm anyway)

@benoit-pierre
Copy link
Contributor

Yep, I have PRs for those.

hugleo added a commit to hugleo/android-luajit-launcher that referenced this pull request Sep 29, 2024
Frenzie pushed a commit to koreader/android-luajit-launcher that referenced this pull request Sep 29, 2024
Copy link
Member

@pazos pazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiLuJe: please merge when ready. If you bump base in front please also bump android-luajit-launcher

Thanks!

@NiLuJe
Copy link
Member Author

NiLuJe commented Sep 30, 2024

That'll probably be tomorrow evening ;).

Copy link
Member Author

@NiLuJe NiLuJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)

@NiLuJe NiLuJe merged commit bca8dc2 into koreader:master Oct 1, 2024
4 checks passed
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 1, 2024
NiLuJe added a commit to koreader/koreader that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants