New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos: fix wrap-mupdf library extension #1948

Merged

Frenzie merged 1 commit into koreader:master from benoit-pierre:pr/fix_macos_wrap-mupdf_library_extension

Oct 3, 2024

Contributor

benoit-pierre commented Oct 3, 2024 •

edited by Frenzie

Loading

Cf. koreader/koreader#12546 (comment).

This change is


          macos: fix wrap-mupdf library extension

b4ba8e4

Frenzie merged commit fb1612a into koreader:master

2 checks passed

Member

Frenzie commented Oct 3, 2024

Thanks!

Member

Frenzie commented Oct 3, 2024

Did you also see the others in koreader/koreader#12546 (comment) ?

Contributor Author

benoit-pierre commented Oct 3, 2024

Yes, but those are Lua modules, so they get a .so extension.

benoit-pierre deleted the pr/fix_macos_wrap-mupdf_library_extension branch

October 3, 2024 21:38

Member

Frenzie commented Oct 4, 2024

They do? Hm, ok.

Contributor Author

benoit-pierre commented Oct 4, 2024

Yeah, apart from Windows, LuaJIT default package path uses ?.so.

benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request


          bump base, macOS edition

7e7f862

- koreader/koreader-base#1948
- koreader/koreader-base#1949
- koreader/koreader-base#1950
- koreader/koreader-base#1951
- koreader/koreader-base#1952
- koreader/koreader-base#1953
- koreader/koreader-base#1954
- koreader/koreader-base#1955
- koreader/koreader-base#1957
- koreader/koreader-base#1958

benoit-pierre mentioned this pull request

bump base, macOS edition koreader/koreader#12605

Merged

pazos pushed a commit to koreader/koreader that referenced this pull request


          bump base, macOS edition (#12605)

db4a07e

- koreader/koreader-base#1948
- koreader/koreader-base#1949
- koreader/koreader-base#1950
- koreader/koreader-base#1951
- koreader/koreader-base#1952
- koreader/koreader-base#1953
- koreader/koreader-base#1954
- koreader/koreader-base#1955
- koreader/koreader-base#1957
- koreader/koreader-base#1958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet