pocketbook: support "extended" key events #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
force-pushed
the
pr/inkview_sdk_v6_update
branch
from
87a2626 to
e45a8b6
Compare
Frenzie
approved these changes
Nov 4, 2024
This was referenced Nov 4, 2024
NiLuJe
reviewed
Nov 4, 2024
benoit-pierre
force-pushed
the
pr/inkview_sdk_v6_update
branch
from
e45a8b6 to
869b0ea
Compare
NiLuJe
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @benoit-pierre)
- drop unused declarations - update to SDK 6, adding declarations for "extended" key events (`EVT_KEYPRESS_EXT` and the like)
Only for devices running with SDK >= 6.
benoit-pierre
force-pushed
the
pr/inkview_sdk_v6_update
branch
from
869b0ea to
fba5c68
Compare
NiLuJe
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only for device running with SDK >= 6.
This cleanup and update the inkview cdecls, dropping unused declarations and adding declarations for "extended" key events (
EVT_KEYPRESS_EXTand the like).For now, "standard" keycodes are negated to avoid conflicts with "extended" (regular linux input) keycodes.
This change is