cmake: fix external projects cmake bug #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around cmake bug https://gitlab.kitware.com/cmake/cmake/-/issues/25428 (introduced in 3.23.0, fixed in 3.27.9): do not create `build.d` dependency files with phony targets (which would keep triggering unnecessary rebuilds of some external projects).
benoit-pierre
force-pushed
the
pr/work_around_cmake_bug
branch
from
aa3c02d to
5e24634
Compare
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Nov 24, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around cmake bug https://gitlab.kitware.com/cmake/cmake/-/issues/25428 (introduced in 3.23.0, fixed in 3.27.9): do not create
build.ddependency files with phony targets (which would keep triggering unnecessary rebuilds of some external projects).This change is