Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/circle: fix ccache cache, take 2 #1997

Merged

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Nov 27, 2024

This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Nov 27, 2024

I imagine this should be ${DOCKER_HOME}/.cache/ccache?

-v "${CCACHE_DIR}:${DOCKER_HOME}/.ccache" \

@benoit-pierre
Copy link
Contributor Author

I imagine this should be ${DOCKER_HOME}/.cache/ccache?

-v "${CCACHE_DIR}:${DOCKER_HOME}/.ccache" \

Not necessarily, since ccache will honor ~/.ccache.

@benoit-pierre
Copy link
Contributor Author

Wait, no, since it won't already exists.

@benoit-pierre benoit-pierre force-pushed the pr/fix_circleci_caching_take_2 branch 3 times, most recently from a58ca47 to 11594ee Compare November 27, 2024 23:39
@benoit-pierre benoit-pierre force-pushed the pr/fix_circleci_caching_take_2 branch from 11594ee to 38a3cb7 Compare November 27, 2024 23:48
@Frenzie
Copy link
Member

Frenzie commented Nov 28, 2024

Wait, no, since it won't already exists.

ccache doesn't do that? That seems a little odd.

@Frenzie Frenzie merged commit 84ffb30 into koreader:master Nov 28, 2024
4 checks passed
@benoit-pierre
Copy link
Contributor Author

Wait, no, since it won't already exists.

ccache doesn't do that? That seems a little odd.

Do what? ccache will automatically create the directory, but prefer ~/.cache/ccache if ~/.ccache does not exists.

Not that it mattered in that instance, since the directory is guaranteed to exists (as a mountpoint for docker), so I could have left it at that.

@benoit-pierre benoit-pierre deleted the pr/fix_circleci_caching_take_2 branch November 30, 2024 11:51
@Frenzie
Copy link
Member

Frenzie commented Nov 30, 2024

Not that it mattered in that instance, since the directory is guaranteed to exists (as a mountpoint for docker), so I could have left it at that.

I meant for consistency and to prevent future confusion, unless there was a reason to have it different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants