-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssh: drop openssl and zlib dependencies #2011
openssh: drop openssl and zlib dependencies #2011
Conversation
We actually don't need them for building the only 2 executables we care about (scp & sftp-server).
I'm not sure if I quite follow. That sounds like you can't use them with servers that only allow compression (weird, I know) or encryption (not so weird). |
# On master:
▸ ./utils/bininfo.py build/arm-kindlepw2-linux-gnueabi/{scp,sftp-server}
build/arm-kindlepw2-linux-gnueabi/scp:
RPATH : $ORIGIN:$ORIGIN/libs
NEEDED : librt.so.1
NEEDED : libc.so.6
build/arm-kindlepw2-linux-gnueabi/sftp-server:
RPATH : $ORIGIN:$ORIGIN/libs
NEEDED : librt.so.1
NEEDED : libc.so.6
▸ sha1sum build/arm-kindlepw2-linux-gnueabi/{scp,sftp-server}
eb136d4d17070482655f1e886a1820b9eed8ee52 build/arm-kindlepw2-linux-gnueabi/scp
93c1d633d0b961f1d5886cac9bc1202622b022ff build/arm-kindlepw2-linux-gnueabi/sftp-server
# This PR:
▸ ./utils/bininfo.py build/arm-kindlepw2-linux-gnueabi/{scp,sftp-server}
build/arm-kindlepw2-linux-gnueabi/scp:
RPATH : $ORIGIN:$ORIGIN/libs
NEEDED : librt.so.1
NEEDED : libc.so.6
build/arm-kindlepw2-linux-gnueabi/sftp-server:
RPATH : $ORIGIN:$ORIGIN/libs
NEEDED : librt.so.1
NEEDED : libc.so.6
▸ sha1sum build/arm-kindlepw2-linux-gnueabi/{scp,sftp-server}
eb136d4d17070482655f1e886a1820b9eed8ee52 build/arm-kindlepw2-linux-gnueabi/scp
93c1d633d0b961f1d5886cac9bc1202622b022ff build/arm-kindlepw2-linux-gnueabi/sftp-server So absolutely no change.
From the OpenSSH Manual:
Dropbear is in charge of the transport layer, so encryption and compression are not handled by the sftp-server binary. After compiling OpenSSH for the emulator, and trying to run the resulting ▸ ./build/x86_64-pc-linux-gnu/scp -C Makefile localhost:
/usr/local/bin/ssh: No such file or directory
./build/x86_64-pc-linux-gnu/scp: Connection closed
▸ strings build/arm-kindlepw2-linux-gnueabi/scp | /usr/bin/grep -x /usr/local/bin/ssh
/usr/local/bin/ssh And indeed, looking at
So scp call ssh to handle the nitty-gritty of connecting and managing the transport layer. It looks like our shipped scp binary is unusable without including the |
But hold on, aren't all of those provided by Dropbear itself? What's OpenSSH needed for at all then? |
Yeah, I don't understand why we don't ship dropbear' |
A confusing situation all around then, but as long as |
There was a thing about dbscp that annoyed me at one point, but it's been so long I can't really recall ;p. (That, or it's simply based on an old snapshot of OpenSSH's scp, so I figured, eh, we already need sftp from OpenSSH, let's just use all of the clients ;p). |
We actually don't need them for building the only 2 executables we care about (scp & sftp-server).
This change is