Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: improve test runner and testsuite isolation #2016

Merged

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Jan 8, 2025

  • initial LUA paths are now setup by the runner itself, so it can be executed directly without needing to manually set them before
  • patch the LUA paths before actually executing the tests to remove the testsuite specific entries (e.g. spec/rocks/…), ensuring tests only have access to shipped packages

This change is Reviewable

- initial LUA paths are now setup by the runner itself, so it can
  be executed directly without needing to manually set them before
- patch the LUA paths before actually executing the tests to remove
  the testsuite specific entries (e.g. `spec/rocks/…`), ensuring
  tests only have access to shipped packages
@benoit-pierre
Copy link
Contributor Author

With this PR the testsuite would fail with the initial version of #2015 (prevent importing a test-only package: dkjson), but it would not help when using lfs instead of koreader-lfs like in koreader/koreader#13004, even after updating busted to master (lunarmodules/busted@a144124, to get lunarmodules/busted#654, which does not seem to work, as even some of the added busted tests don't pass).

@Frenzie Frenzie merged commit 7ecda58 into koreader:master Jan 9, 2025
4 checks passed
@benoit-pierre benoit-pierre deleted the pr/better_testsuite_isolation branch January 9, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants