Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul tools #3

Merged
merged 112 commits into from
Mar 21, 2024
Merged

Overhaul tools #3

merged 112 commits into from
Mar 21, 2024

Conversation

kostrykin
Copy link
Owner

@kostrykin kostrykin commented Mar 15, 2024

Todos:

  • Check whether skimage.io.imread is capable of reading single-channel PNG files. If not, then tools not capable of dealing with multi-channel images should not be allowed to take png as input. — Yes, it is. To reproduce, use cv2.imwrite to write a single-channel PNG file. It can then be read with skimage.io.imread, although skimage.io.imsave cannot write single-channel PNG files.

Overhauled tools:

  • 2d_auto_threshold
  • 2d_feature_extraction
  • 2d_filter_segmentation_by_features
  • 2d_histogram_equalization
  • 2d_simple_filter
  • anisotropic_diffusion
  • bfconvert
  • binary2labelimage
  • binaryimage2points
  • bioformats2raw
  • color-deconvolution
  • colorize_labels
  • concat_channels
  • coordinates_of_roi
  • count_objects
  • curve_fitting
  • detection_viz
  • imagecoordinates_flipaxis
  • image_info
  • image_math
  • image_registration_affine
  • labelimage2points
  • label_to_binary
  • landmark_registration
  • mahotas-features
  • mergeneighboursinlabelimage
  • morphological_operations
  • orientationpy
  • overlay_images
  • permutate_axis
  • points2binaryimage
  • points2labelimage
  • points_association_nn
  • projective_transformation
  • projective_transformation_points
  • rfove
  • roi2binaryimage
  • scale_image
  • segmetrics
  • slice_image
  • split_labelmap
  • spot_detection_2d
  • superdsm
  • unzip
  • visceral-evaluatesegmentation
  • voronoi_tessellation
  • wsi_extract_top_view

Unmaintained:

  • curl_post
  • 3d_tensor_feature_dimension_reduction (hidden)

@kostrykin
Copy link
Owner Author

kostrykin commented Mar 19, 2024

Next tool should be scale_image.

  • Add option to scale_image and 2d_simple_filter to either preserve the brightness, or preserve the values range. Alternatively, make scale_image and 2d_simple_filter preserve the dtype of the image.
  • Add TIFF support to scale_image
  • Verify that Pillow cannot read float TIFFs (and check whether we can use tifffile in Galaxy)

@kostrykin
Copy link
Owner Author

kostrykin commented Mar 20, 2024

Todo:

  • Add test case with float TIFFs for 2d_simple_filter

Note for upstream PR: The 2d_simple_filter tool now preserves the range of values (a074b7d).

Next tools in line:

  • image_math
  • morphological_operations
  • orientationpy
  • split_labelmap

@kostrykin
Copy link
Owner Author

Note for upstream PR: The concat_images tool now supports either preserving the range of values or the image brightness (69f59ba).

@kostrykin kostrykin marked this pull request as ready for review March 21, 2024 13:56
@kostrykin kostrykin merged commit 5fd315e into overhaul/upstream Mar 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant