-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you still maintain this project? #1954
Comments
Hey, @kragniz isn't maintaining this project. I've been hoping to revive it but haven't found the time yet. As noted at #1719 (comment), https://opendev.org/openstack/etcd3gw is a good alternative to use for now. |
hey, @stephenfin , is there any chance for me to become one of the contributors, because I use this in my project, and want to update it. |
@mingxing47 I'd be more than happy to review PRs and add you then, if that works for you? Would be good to have multiple sets of eyes on the fix. I have tried to fix this but got stuck because |
I would be more than happy to help you fix this and be a contributor |
All this extra energy has revived me - I'm going to do a bit of maintainance and help @jkawamoto merge their patches |
@stephenfin I've just realized the pifpaf's issue you mentioned in #1954 (comment). How about this patch? diff --git a/.build.yml b/.build.yml
index efc0a28..eb2896a 100644
--- a/.build.yml
+++ b/.build.yml
@@ -6,7 +6,7 @@ packages:
sources:
- https://github.com/kragniz/python-etcd3
environment:
- TEST_ETCD_VERSION: v3.3.10
+ TEST_ETCD_VERSION: v3.4.20
tasks:
- test: |
cd python-etcd3
diff --git a/Dockerfile b/Dockerfile
index 9e7abcd..a9e4cce 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,7 +4,7 @@ ARG HTTP_PROXY
ARG http_proxy
ARG HTTPS_PROXY
ARG https_proxy
-ENV TEST_ETCD_VERSION v3.3.10
+ENV TEST_ETCD_VERSION v3.4.20
RUN curl -L https://github.com/etcd-io/etcd/releases/download/${TEST_ETCD_VERSION}/etcd-${TEST_ETCD_VERSION}-linux-amd64.tar.gz | tar xzvf -
ENV PATH $PATH:/etcd-${TEST_ETCD_VERSION}-linux-amd64
diff --git a/docker-compose.yml b/docker-compose.yml
index d206bc3..fe8fad4 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -8,12 +8,3 @@ services:
- http_proxy
- HTTPS_PROXY
- https_proxy
- links:
- - etcd
- environment:
- - PYTHON_ETCD_HTTP_URL=http://etcd:2379
- etcd:
- ports:
- - "2379:2379"
- image: quay.io/coreos/etcd
- command: etcd --initial-cluster-state new --listen-client-urls http://0.0.0.0:2379 --advertise-client-urls http://127.0.0.1:2379
diff --git a/tox.ini b/tox.ini
index 0dcea40..63580b2 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14,6 +14,9 @@ deps=
-r{toxinidir}/requirements/test.txt
commands =
pip install -U pip
+ # This is a workaround to install pifpaf with patch https://github.com/jd/pifpaf/pull/135.
+ # If a new version is released, remove this.
+ pip install git+https://github.com/jd/pifpaf.git@7496e5e1c3d890eadcc491f2bcc1160d9395d8b0
pifpaf -e PYTHON run etcd --cluster -- py.test --cov=etcd3 --cov-report= --basetemp={envtmpdir} {posargs}
[testenv:coverage] I can pass tests. (I use |
I opened jd/pifpaf#156. Tests with etcd v3.5 work for me with this patch: diff --git a/.build.yml b/.build.yml
index efc0a28..b9d191e 100644
--- a/.build.yml
+++ b/.build.yml
@@ -6,7 +6,7 @@ packages:
sources:
- https://github.com/kragniz/python-etcd3
environment:
- TEST_ETCD_VERSION: v3.3.10
+ TEST_ETCD_VERSION: v3.5.4
tasks:
- test: |
cd python-etcd3
diff --git a/Dockerfile b/Dockerfile
index 9e7abcd..9ad53dd 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,7 +4,7 @@ ARG HTTP_PROXY
ARG http_proxy
ARG HTTPS_PROXY
ARG https_proxy
-ENV TEST_ETCD_VERSION v3.3.10
+ENV TEST_ETCD_VERSION v3.5.4
RUN curl -L https://github.com/etcd-io/etcd/releases/download/${TEST_ETCD_VERSION}/etcd-${TEST_ETCD_VERSION}-linux-amd64.tar.gz | tar xzvf -
ENV PATH $PATH:/etcd-${TEST_ETCD_VERSION}-linux-amd64
diff --git a/docker-compose.yml b/docker-compose.yml
index d206bc3..fe8fad4 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -8,12 +8,3 @@ services:
- http_proxy
- HTTPS_PROXY
- https_proxy
- links:
- - etcd
- environment:
- - PYTHON_ETCD_HTTP_URL=http://etcd:2379
- etcd:
- ports:
- - "2379:2379"
- image: quay.io/coreos/etcd
- command: etcd --initial-cluster-state new --listen-client-urls http://0.0.0.0:2379 --advertise-client-urls http://127.0.0.1:2379
diff --git a/tox.ini b/tox.ini
index 0dcea40..9d31c38 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14,6 +14,9 @@ deps=
-r{toxinidir}/requirements/test.txt
commands =
pip install -U pip
+ # This is a workaround to install pifpaf with patch https://github.com/jd/pifpaf/pull/156.
+ # If a new version is released, remove this.
+ pip install git+https://github.com/jkawamoto/pifpaf.git@etcd
pifpaf -e PYTHON run etcd --cluster -- py.test --cov=etcd3 --cov-report= --basetemp={envtmpdir} {posargs}
[testenv:coverage] |
@stephenfin Fixed the above problem, will a new version be released soon? |
@kragniz hi, When will a new version be released |
Do you still maintain this project?
The text was updated successfully, but these errors were encountered: