Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you still maintain this project? #1954

Closed
Sanfield opened this issue Aug 8, 2022 · 10 comments
Closed

Do you still maintain this project? #1954

Sanfield opened this issue Aug 8, 2022 · 10 comments

Comments

@Sanfield
Copy link

Sanfield commented Aug 8, 2022

Do you still maintain this project?

@stephenfin
Copy link
Collaborator

Hey, @kragniz isn't maintaining this project. I've been hoping to revive it but haven't found the time yet. As noted at #1719 (comment), https://opendev.org/openstack/etcd3gw is a good alternative to use for now.

@SimonMing47
Copy link

SimonMing47 commented Aug 10, 2022

hey, @stephenfin , is there any chance for me to become one of the contributors, because I use this in my project, and want to update it.

@stephenfin
Copy link
Collaborator

@mingxing47 I'd be more than happy to review PRs and add you then, if that works for you? Would be good to have multiple sets of eyes on the fix. I have tried to fix this but got stuck because pifpaf, which we use for running tests, is broken on recent versions of etcd. I've started fixing that but never finished it. We probably want to migrate away from pifpaf first and switch to GitHub Actions.

@Sanfield
Copy link
Author

I would be more than happy to help you fix this and be a contributor

@kragniz
Copy link
Owner

kragniz commented Aug 12, 2022

All this extra energy has revived me - I'm going to do a bit of maintainance and help @jkawamoto merge their patches

@jkawamoto
Copy link
Contributor

I'm glad to help with this project. Hopefully, #1959 and #1962 fix CI errors.

@jkawamoto
Copy link
Contributor

@stephenfin I've just realized the pifpaf's issue you mentioned in #1954 (comment).

How about this patch?

diff --git a/.build.yml b/.build.yml
index efc0a28..eb2896a 100644
--- a/.build.yml
+++ b/.build.yml
@@ -6,7 +6,7 @@ packages:
 sources:
   - https://github.com/kragniz/python-etcd3
 environment:
-  TEST_ETCD_VERSION: v3.3.10
+  TEST_ETCD_VERSION: v3.4.20
 tasks:
   - test: |
       cd python-etcd3
diff --git a/Dockerfile b/Dockerfile
index 9e7abcd..a9e4cce 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,7 +4,7 @@ ARG HTTP_PROXY
 ARG http_proxy
 ARG HTTPS_PROXY
 ARG https_proxy
-ENV TEST_ETCD_VERSION v3.3.10
+ENV TEST_ETCD_VERSION v3.4.20
 
 RUN curl -L https://github.com/etcd-io/etcd/releases/download/${TEST_ETCD_VERSION}/etcd-${TEST_ETCD_VERSION}-linux-amd64.tar.gz | tar xzvf -
 ENV PATH $PATH:/etcd-${TEST_ETCD_VERSION}-linux-amd64
diff --git a/docker-compose.yml b/docker-compose.yml
index d206bc3..fe8fad4 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -8,12 +8,3 @@ services:
         - http_proxy
         - HTTPS_PROXY
         - https_proxy
-    links:
-      - etcd
-    environment:
-      - PYTHON_ETCD_HTTP_URL=http://etcd:2379
-  etcd:
-    ports:
-      - "2379:2379"
-    image: quay.io/coreos/etcd
-    command: etcd --initial-cluster-state new --listen-client-urls http://0.0.0.0:2379 --advertise-client-urls http://127.0.0.1:2379
diff --git a/tox.ini b/tox.ini
index 0dcea40..63580b2 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14,6 +14,9 @@ deps=
     -r{toxinidir}/requirements/test.txt
 commands =
     pip install -U pip
+    # This is a workaround to install pifpaf with patch https://github.com/jd/pifpaf/pull/135.
+    # If a new version is released, remove this.
+    pip install git+https://github.com/jd/pifpaf.git@7496e5e1c3d890eadcc491f2bcc1160d9395d8b0
     pifpaf -e PYTHON run etcd --cluster -- py.test --cov=etcd3 --cov-report= --basetemp={envtmpdir} {posargs}
 
 [testenv:coverage]

I can pass tests. (I use docker-compose up). Unfortunately, jd/pifpaf#135 doesn't work with etcd v3.5.4. I'm fixing it, and hopefully, I can open a PR.

@jkawamoto
Copy link
Contributor

I opened jd/pifpaf#156.

Tests with etcd v3.5 work for me with this patch:

diff --git a/.build.yml b/.build.yml
index efc0a28..b9d191e 100644
--- a/.build.yml
+++ b/.build.yml
@@ -6,7 +6,7 @@ packages:
 sources:
   - https://github.com/kragniz/python-etcd3
 environment:
-  TEST_ETCD_VERSION: v3.3.10
+  TEST_ETCD_VERSION: v3.5.4
 tasks:
   - test: |
       cd python-etcd3
diff --git a/Dockerfile b/Dockerfile
index 9e7abcd..9ad53dd 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -4,7 +4,7 @@ ARG HTTP_PROXY
 ARG http_proxy
 ARG HTTPS_PROXY
 ARG https_proxy
-ENV TEST_ETCD_VERSION v3.3.10
+ENV TEST_ETCD_VERSION v3.5.4
 
 RUN curl -L https://github.com/etcd-io/etcd/releases/download/${TEST_ETCD_VERSION}/etcd-${TEST_ETCD_VERSION}-linux-amd64.tar.gz | tar xzvf -
 ENV PATH $PATH:/etcd-${TEST_ETCD_VERSION}-linux-amd64
diff --git a/docker-compose.yml b/docker-compose.yml
index d206bc3..fe8fad4 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -8,12 +8,3 @@ services:
         - http_proxy
         - HTTPS_PROXY
         - https_proxy
-    links:
-      - etcd
-    environment:
-      - PYTHON_ETCD_HTTP_URL=http://etcd:2379
-  etcd:
-    ports:
-      - "2379:2379"
-    image: quay.io/coreos/etcd
-    command: etcd --initial-cluster-state new --listen-client-urls http://0.0.0.0:2379 --advertise-client-urls http://127.0.0.1:2379
diff --git a/tox.ini b/tox.ini
index 0dcea40..9d31c38 100644
--- a/tox.ini
+++ b/tox.ini
@@ -14,6 +14,9 @@ deps=
     -r{toxinidir}/requirements/test.txt
 commands =
     pip install -U pip
+    # This is a workaround to install pifpaf with patch https://github.com/jd/pifpaf/pull/156.
+    # If a new version is released, remove this.
+    pip install git+https://github.com/jkawamoto/pifpaf.git@etcd
     pifpaf -e PYTHON run etcd --cluster -- py.test --cov=etcd3 --cov-report= --basetemp={envtmpdir} {posargs}
 
 [testenv:coverage]

@Sanfield
Copy link
Author

@stephenfin Fixed the above problem, will a new version be released soon?

@SimonMing47
Copy link

@kragniz hi, When will a new version be released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants