Update dependencies #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- options_success_status: allows to define the options success status code. - options_passthrough: Instructs preflight to let other potential next handlers to process the OPTIONS method. Turn this on if your application handles OPTIONS. - allow_private_network: Indicates whether to accept cross-origin requests over a private network. Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
|
Ready! |
Signed-off-by: Daniel Ortiz <dortiz@krakend.io>
kpacha
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update dependencies
the
OPTIONScall now returns204intead of200allowed headers are "normalized" to lowercase, however, when those are received from the client, those headers are not normalized, so, are going to fail if not sent in lower case. If we wanted to allow different case to match, we should lowercase it here: https://github.com/rs/cors/blob/master/cors.go#L368 : however, that is a "feature" not a bug :
SortedSet.Subsumesbug rs/cors#180empty configuration no longer allows all the requests by default : now you have to specify wildcards for the
allowed_originsand theallowed_headers. The last commit adapts the config reader to maintain behaviour.