fix plot_voltage_components to work when time doesn't start at 0

kratman · Mar 20, 2024 · 4bad8f3 · 4bad8f3
1 parent 9bf979b
commit 4bad8f3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,7 @@
 
 ## Bug Fixes
 
+- `plot_voltage_components` now works even if the time does not start at 0 ([#3915](https://github.com/pybamm-team/PyBaMM/pull/3915))
 - Fixed bug where separator porosity was used in calculation instead of transport efficiency ([#3905](https://github.com/pybamm-team/PyBaMM/pull/3905))
 - Initial voltage can now match upper or lower cut-offs exactly ([#3842](https://github.com/pybamm-team/PyBaMM/pull/3842))
 - Fixed a bug where 1+1D and 2+1D models would not work with voltage or power controlled experiments([#3829](https://github.com/pybamm-team/PyBaMM/pull/3829))

diff --git a/pybamm/plotting/plot_voltage_components.py b/pybamm/plotting/plot_voltage_components.py
@@ -95,16 +95,16 @@ def plot_voltage_components(
     time = solution["Time [h]"].entries
     if split_by_electrode is False:
         ocv = solution["Battery open-circuit voltage [V]"]
-        initial_ocv = ocv(0)
+        initial_ocv = ocv(time[0])
         ocv = ocv.entries
         ax.fill_between(
             time, ocv, initial_ocv, **kwargs_fill, label="Open-circuit voltage"
         )
     else:
         ocp_n = solution["Battery negative electrode bulk open-circuit potential [V]"]
         ocp_p = solution["Battery positive electrode bulk open-circuit potential [V]"]
-        initial_ocp_n = ocp_n(0)
-        initial_ocp_p = ocp_p(0)
+        initial_ocp_n = ocp_n(time[0])
+        initial_ocp_p = ocp_p(time[0])
         initial_ocv = initial_ocp_p - initial_ocp_n
         delta_ocp_n = ocp_n.entries - initial_ocp_n
         delta_ocp_p = ocp_p.entries - initial_ocp_p