Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade flutter to 3.16.0 #679

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

selfisekai
Copy link
Contributor

@selfisekai selfisekai commented Nov 16, 2023

@selfisekai selfisekai marked this pull request as ready for review November 16, 2023 01:23
@selfisekai selfisekai marked this pull request as draft November 16, 2023 01:27
@krille-chan
Copy link
Owner

Looks like we did the same at the same time while we fixed different issues :D you wanna cherry-pick my changes to the didWillPopScope and I close my PR?

@selfisekai
Copy link
Contributor Author

sure

@selfisekai
Copy link
Contributor Author

but there's still something up with the android pipeline here

@krille-chan
Copy link
Owner

but there's still something up with the android pipeline here

Maybe using git import of https://github.com/famedly/flutter_openssl_crypto does fix it?

@krille-chan
Copy link
Owner

Oof, still no luck. Maybe upgrading Kotlin to 1.9.20 helps? No idea...

@selfisekai selfisekai marked this pull request as ready for review November 18, 2023 21:57
Copy link
Owner

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much <3

@krille-chan krille-chan merged commit 83ce07c into krille-chan:main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants