-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KOSM #593
base: develop
Are you sure you want to change the base?
Add support for KOSM #593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mntzrr I'm sorry, i missed the needed changes to .distignore
with this PR. Should have mentioned that earlier as well.
You need to add the new composer-depencencies
files, any potential tmp
or vendor
folders, and the scoper.custom.php
file to these as well. For the composer files, i suggest not using a wildcard with composer as the base, since that might exclude files in the dependencies folder as well, which handles the autoloading for them. So exclude them more directly than that.
We have this in other plugins that use a similar build process. So you can reference those.
We will also need to add changes to the deployment action before we release this, since we need to add the composer step to build the actual release. But that should be fairly simple to do. We can discuss this internally today if you have time.
Task: https://app.clickup.com/t/8694bpdkb