Fixed Issue when Caching of SwiftTemplate Binary Fails #1323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, whenever Sourcery is done with compiling
SwiftTemplate
executable binary, it tries to move this binary into a shared cache folder.However, if Sourcery is executed concurrently, i.e.
sourcery
binary is launched multiple times with a same.swifttemplate
, an error is thrown because one of the sourcery executions was able to move the same file from within a guardingif
statement:Details
To resolve this, the move of the compiled
SwiftTemplate
binary is nowoptional
, i.e. thrown error is ignored. Essentially, it is irrelevant if the binary was cached or not, since Sourcery's task is to execute SwiftTemplate and not cache SwiftTemplate.Verification is done using a new unit test.