Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add festival emojis and dates for loading screen #561

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 23, 2025

TL;DR

Added support for additional festivals and their corresponding emojis in the loading screen.

What changed?

  • Added new festival types including Australia Day, Rose Day, Propose Day, and various Valentine's week celebrations
  • Expanded festival emoji mappings with culturally diverse celebrations like Holi, Eid, Mardi Gras, and Vivid Sydney
  • Updated Christmas emojis with additional seasonal icons
  • Added date mappings for new festivals, including multi-day events like Mardi Gras 2025
  • Added TODO comments for future improvements regarding date range handling and remote configuration

How to test?

  1. Change system date to match different festival dates
  2. Verify appropriate festival emojis appear on loading screens
  3. Key dates to test:
    • Valentine's week (Feb 7-14)
    • Mardi Gras (Feb 15 - March 2, 2025)
    • Vivid Sydney (May 23-29)
    • Australia Day (Jan 26)

Why make this change?

To enhance user experience by displaying culturally relevant and diverse festival emojis during loading screens, making the app more engaging and inclusive for users across different cultural celebrations and events.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz force-pushed the 01-23-update_festival_emojis branch from f74ccd0 to 682fb9b Compare January 23, 2025 10:43
@ksharma-xyz ksharma-xyz changed the title Update Festival emojis UI: Add festival emojis and dates for loading screen Jan 23, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 23, 2025 10:45
Copy link
Owner Author

ksharma-xyz commented Jan 23, 2025

Merge activity

  • Jan 23, 3:18 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 23, 3:18 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz merged commit 9eab850 into main Jan 23, 2025
4 checks passed
@ksharma-xyz ksharma-xyz deleted the 01-23-update_festival_emojis branch January 23, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant