Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(non-k8s): Add HSP test suite for non-k8s mode #1857

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

navin772
Copy link
Member

Purpose of PR?:

Partially fixes #1625
Adds the HSP test suite for non-k8s mode

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@daemon1024
Copy link
Member

Can we include #1879 here?

@daemon1024
Copy link
Member

@navin772 why does the systemd test fail here? It cannot find the cov out file.

@navin772
Copy link
Member Author

Some of the tests are failing, so the Kill KubeArmor Process step was skipped, hence no coverage file was generated.

@daemon1024
Copy link
Member

@navin772 what is failing? how can I help?

@navin772
Copy link
Member Author

@daemon1024 4 out of the new 8 non-k8s HSP tests are failing which were passing earlier, was there any changes to non-k8s recently?
I will take a detailed look and try to run the tests locally this weekend.

navin772 and others added 4 commits November 7, 2024 12:49
Signed-off-by: Navin Chandra <navinchandra772@gmail.com>
Signed-off-by: Navin Chandra <navinchandra772@gmail.com>
Signed-off-by: Navin Chandra <navinchandra772@gmail.com>

Co-authored-by: Barun Acharya <barun1024@gmail.com>
Signed-off-by: Navin Chandra <navinchandra772@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI(tests): ginkgo tests for host security capabilities of KubeArmor
2 participants