Disable SC1017,SC2086,SC2070 rules when shellcheck and did changes in…

… sh files to address the formattings according to shellcheck Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
kubeflow · Jul 1, 2024 · 7c29d8a · 7c29d8a
1 parent 6126798
commit 7c29d8a
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/.shellcheckrc b/.shellcheckrc
@@ -1,2 +1,2 @@
 # ~/.shellcheckrc
-disable=SC1017
+disable=SC1017,SC2086,SC2070
diff --git a/apps/kfp-tekton/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh b/apps/kfp-tekton/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
@@ -1,3 +1,4 @@
+#!/bin/sh
 # Build venv with required packages
 VENV=".venv"
 PYTHON_VENV="${VENV}/bin/python"

diff --git a/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh b/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # Build venv with required packages
 VENV=".venv"
 PYTHON_VENV="${VENV}/bin/python"

diff --git a/hack/synchronize-istio-cni-manifests.sh b/hack/synchronize-istio-cni-manifests.sh
@@ -1,5 +1,5 @@
-@ -1,88 +0,0 @@
 #!/usr/bin/env bash
+@ -1,88 +0,0 @@
 
 # This script aims at helping create a PR to update the manifests of the
 # knative.

diff --git a/hack/synchronize-istio-manifests.sh b/hack/synchronize-istio-manifests.sh
@@ -1,4 +1,4 @@
-# #!/usr/bin/env bash
+# !/usr/bin/env bash
 
 # # This script aims at helping create a PR to update the manifests of Istio
 # # This script: