From 7c29d8a6eb6fa70274ac49d52785d002abedd0f2 Mon Sep 17 00:00:00 2001
From: hansinikarunarathne
 <107214435+hansinikarunarathne@users.noreply.github.com>
Date: Tue, 2 Jul 2024 00:53:17 +0530
Subject: [PATCH] Disable SC1017,SC2086,SC2070 rules when shellcheck and did
 changes in sh files to address the formattings according to shellcheck

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
---
 .shellcheckrc                                                   | 2 +-
 .../multi-user/pipelines-profile-controller/run_tests.sh        | 1 +
 .../multi-user/pipelines-profile-controller/run_tests.sh        | 1 +
 hack/synchronize-istio-cni-manifests.sh                         | 2 +-
 hack/synchronize-istio-manifests.sh                             | 2 +-
 5 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.shellcheckrc b/.shellcheckrc
index 98a56bdd29..34deb1a03e 100644
--- a/.shellcheckrc
+++ b/.shellcheckrc
@@ -1,2 +1,2 @@
 # ~/.shellcheckrc
-disable=SC1017
\ No newline at end of file
+disable=SC1017,SC2086,SC2070
\ No newline at end of file
diff --git a/apps/kfp-tekton/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh b/apps/kfp-tekton/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
index 4933ec79a8..be33353dfe 100755
--- a/apps/kfp-tekton/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
+++ b/apps/kfp-tekton/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
@@ -1,3 +1,4 @@
+#!/bin/sh
 # Build venv with required packages
 VENV=".venv"
 PYTHON_VENV="${VENV}/bin/python"
diff --git a/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh b/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
index 4933ec79a8..480c215f19 100755
--- a/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
+++ b/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/run_tests.sh
@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # Build venv with required packages
 VENV=".venv"
 PYTHON_VENV="${VENV}/bin/python"
diff --git a/hack/synchronize-istio-cni-manifests.sh b/hack/synchronize-istio-cni-manifests.sh
index 5a6d4fd74d..81c04b3b53 100644
--- a/hack/synchronize-istio-cni-manifests.sh
+++ b/hack/synchronize-istio-cni-manifests.sh
@@ -1,5 +1,5 @@
-@ -1,88 +0,0 @@
 #!/usr/bin/env bash
+@ -1,88 +0,0 @@
 
 # This script aims at helping create a PR to update the manifests of the
 # knative.
diff --git a/hack/synchronize-istio-manifests.sh b/hack/synchronize-istio-manifests.sh
index 6a4c8987de..f5a0d89c08 100644
--- a/hack/synchronize-istio-manifests.sh
+++ b/hack/synchronize-istio-manifests.sh
@@ -1,4 +1,4 @@
-# #!/usr/bin/env bash
+# !/usr/bin/env bash
 
 # # This script aims at helping create a PR to update the manifests of Istio
 # # This script: