fix mysql deployment strategy (#1562) (#1643)

* fix mysql deployment strategy (#1562) (cherry picked from commit 6c4f265) * resolve tests for azure
kubeflow · Nov 16, 2020 · fc9fe83 · fc9fe83
1 parent 514d0f2
commit fc9fe83
Show file tree

Hide file tree

Showing 26 changed files with 53 additions and 1 deletion.
diff --git a/katib/katib-controller/base/katib-mysql-deployment.yaml b/katib/katib-controller/base/katib-mysql-deployment.yaml
@@ -11,6 +11,8 @@ spec:
     matchLabels:
       app: katib
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       name: katib-mysql

diff --git a/metadata/overlays/db/metadata-db-deployment.yaml b/metadata/overlays/db/metadata-db-deployment.yaml
@@ -5,10 +5,12 @@ metadata:
   labels:
     component: db
 spec:
+  replicas: 1
   selector:
     matchLabels:
       component: db
-  replicas: 1
+  strategy:
+    type: Recreate
   template:
     metadata:
       name: db

diff --git a/...atib/installs/katib-standalone-ibm/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/...atib/installs/katib-standalone-ibm/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/katib/installs/katib-standalone/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/katib/installs/katib-standalone/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/aws/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/aws/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/aws/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/aws/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -12,6 +12,8 @@ spec:
     matchLabels:
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/azure/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/azure/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/azure/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/azure/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -12,6 +12,8 @@ spec:
     matchLabels:
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/examples/alice/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/examples/alice/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/examples/alice/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/examples/alice/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -12,6 +12,8 @@ spec:
     matchLabels:
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/gcp/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/gcp/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/gcp/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/gcp/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -12,6 +12,8 @@ spec:
     matchLabels:
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/generic/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/generic/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/generic/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/generic/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -12,6 +12,8 @@ spec:
     matchLabels:
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/ibm/application/katib/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/ibm/application/katib/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/ibm/application/metadata/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/ibm/application/metadata/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/name: metadata
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/ibm/multi-user/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/ibm/multi-user/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/ibm/multi-user/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/ibm/multi-user/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/name: metadata
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/ibm/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/ibm/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/ibm/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/ibm/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/name: metadata
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/kubernetes/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/tests/stacks/kubernetes/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/tests/stacks/kubernetes/test_data/expected/apps_v1_deployment_metadata-db.yaml b/tests/stacks/kubernetes/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -12,6 +12,8 @@ spec:
     matchLabels:
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/...stacks/openshift/application/katib/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/...stacks/openshift/application/katib/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -16,6 +16,8 @@ spec:
       app.kubernetes.io/component: katib
       app.kubernetes.io/name: katib-controller
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/...cks/openshift/application/metadata/test_data/expected/apps_v1_deployment_metadata-db.yaml b/...cks/openshift/application/metadata/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -12,6 +12,8 @@ spec:
     matchLabels:
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/...cy_kustomizations/katib-controller/test_data/expected/apps_v1_deployment_katib-mysql.yaml b/...cy_kustomizations/katib-controller/test_data/expected/apps_v1_deployment_katib-mysql.yaml
@@ -24,6 +24,8 @@ spec:
       app.kubernetes.io/part-of: kubeflow
       app.kubernetes.io/version: 0.8.0
       component: mysql
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations:

diff --git a/...sts/legacy_kustomizations/metadata/test_data/expected/apps_v1_deployment_metadata-db.yaml b/...sts/legacy_kustomizations/metadata/test_data/expected/apps_v1_deployment_metadata-db.yaml
@@ -24,6 +24,8 @@ spec:
       app.kubernetes.io/version: 0.2.1
       component: db
       kustomize.component: metadata
+  strategy:
+    type: Recreate
   template:
     metadata:
       annotations: