Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add juliusvonkohout to wg-manifests-leads group #2337

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Dec 1, 2022

Follow up of #2493
See also kubeflow/internal-acls#584 and #2432

Root Approver requirements from https://github.com/kubeflow/community/blob/master/wg-manifests/charter.md

The goal of the requirements is to quantify the main pillars that we documented
above. The high level reasoning is that approvers should have lead efforts and
have expertise in the different processes and artefacts maintained in this repo
as well as be invested in the community of the WG.

In addition i am also owner of manifests/contrib , especially Ray and networkpolicies and have several other small PRs as for example

#2357
#2348
#2298
#2013
#2329
#2383

@juliusvonkohout
Copy link
Member Author

/assign @kimwnasptd

@jbottum
Copy link

jbottum commented Dec 1, 2022

@kimwnasptd this seems like a valid request and I would like your input. If/when this is approved, what would be Julius' titles - Manifest WG Tech Lead, reviewer, approver and maintainer ? How strict are the requirements and responsibilities (attending WG meetings, etc.)?

@DomFleischmann
Copy link
Contributor

DomFleischmann commented Apr 4, 2023

@kimwnasptd I think this would be very beneficial, what do you think, could we proceed with this?

@juliusvonkohout juliusvonkohout changed the title Add juliusvonkohout to wg-manifests-leads group WIP: Add juliusvonkohout to wg-manifests-leads group Jul 27, 2023
@juliusvonkohout juliusvonkohout marked this pull request as draft July 27, 2023 16:32
@juliusvonkohout juliusvonkohout marked this pull request as ready for review September 28, 2023 16:10
@juliusvonkohout juliusvonkohout changed the title WIP: Add juliusvonkohout to wg-manifests-leads group Add juliusvonkohout to wg-manifests-leads group Sep 28, 2023
@kimwnasptd
Copy link
Member

As discussed in the last Manifests WG meetings, this PR has been long overdue. @juliusvonkohout thank you very much for all your contributions and really looking forward to next steps!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Nov 22, 2023
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a684c72 into kubeflow:master Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants