Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for rootless Kubeflow #2527

Merged
merged 13 commits into from
Sep 21, 2023

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Sep 13, 2023

Which issue is resolved by this Pull Request:
Related to #2528

Description of your changes:
Add proposal for rootless Kubeflow.

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

Copy link
Member

@annajung annajung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started on this, I left a few comments to help drive out the proposal a little more to see specific details be added to the proposal

proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
proposals/20200913-rootlessKubeflow.md Outdated Show resolved Hide resolved
@juliusvonkohout
Copy link
Member Author

Thanks for getting started on this, I left a few comments to help drive out the proposal a little more to see specific details be added to the proposal

i hope to have addressed all of your comments

@kimwnasptd
Copy link
Member

We discussed and reviewed this live in the Manifests WG meeting on Sept 21 of 2023 and worked a little bit on the structure. This is a really great proposal, great work @juliusvonkohout

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5835025 into kubeflow:master Sep 21, 2023
3 checks passed
@juliusvonkohout juliusvonkohout mentioned this pull request May 7, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants