Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update owner files #2706

Merged
merged 3 commits into from
May 27, 2024
Merged

Update owner files #2706

merged 3 commits into from
May 27, 2024

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented May 7, 2024

@krishnadurai @lluunn @yanniszark @kkasravi @adrian555 @animeshsingh @Tomcli @yuzisun @jlewi
@kunmingg @ellistarn @yuzisun @cliveseldon @deadeyegoodwin @ryandawsonuk @SachinVarghese @axsaucedo

please ping here if you are still active and want to contribute to the 1.9 release. Then i can revert and add you back again.

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

/hold

@juliusvonkohout
Copy link
Member Author

CC @StefanoFioravanzo since i wanted to merge this with @rimolive

@StefanoFioravanzo
Copy link
Member

@juliusvonkohout shall we give a little bit more time for folks to comment if want to keep their names in these files? Also, is this a release blocker?

@juliusvonkohout
Copy link
Member Author

@juliusvonkohout shall we give a little bit more time for folks to comment if want to keep their names in these files? Also, is this a release blocker?

Yes, i will hold it for two weeks and see what happens. But most of them if not all were inactive for 1.8 already.

Even with a lgtm I will wait. This is not a release blocker.

@juliusvonkohout
Copy link
Member Author

No response for 3 weeks now. Lets move on.

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rimolive
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label May 27, 2024
@juliusvonkohout
Copy link
Member Author

/unhold

@google-oss-prow google-oss-prow bot merged commit ecc04a5 into master May 27, 2024
23 checks passed
biswajit-9776 pushed a commit to biswajit-9776/manifests that referenced this pull request May 29, 2024
* Update owner files

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* ramonpzg is not a member

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* add back yuzisun

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
rimolive pushed a commit to rimolive/manifests that referenced this pull request Jun 3, 2024
* Update owner files

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* ramonpzg is not a member

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* add back yuzisun

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
juliusvonkohout added a commit that referenced this pull request Jun 4, 2024
* Update owner files

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* ramonpzg is not a member

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* add back yuzisun

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout deleted the remove-inactive-owners branch June 24, 2024 08:52
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
* Update owner files

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* ramonpzg is not a member

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* add back yuzisun

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove inactive owners
3 participants