Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading istio to v1.18.7 #2739

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

biswajit-9776
Copy link
Contributor

@biswajit-9776 biswajit-9776 commented Jun 3, 2024

Pull Request Template for Kubeflow manifests Issues

  • Please include a summary of changes and the related issue.
  • List any dependencies that are required for this change.
  • Please delete the options that are not relevant.
  • The following checklist will help you to satisfy the requirements.

✏️ A brief description of the changes

I updated istio version 1.17.5 to 1.18.7

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link of the issue here.

The following issues are related, because ...

✅ Unit Test Checklist

  • 🛠️ Make sure you have installed kustomize == 5.2.1+
  • ✍️ Have you written new tests for your core changes, as applicable?
  • 🔄 Have you successfully run existing tests with your changes ?
  • 🚀 Have you successfully run existing and new tests with your changes ?

✅ Contributor checklist


You can join our slack channel wg-manifests here. This link also contains our meeting schedule.

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jun 3, 2024

TODO:

  • Update istio-cni to 1.18.7 as well
  • delete the istio 1.17 folders
  • fix all tests
  • Update the readme
  • Transform the readme into a script as we have it in /hack to upgrade synchronize istio manifests in an automated manner next time
  • For istio-cni we need a script as well
  • use the script to update to in several PRs to 1.19, then 1.20, then 1.21 and 1.22 for istio and istio-cni

@juliusvonkohout juliusvonkohout changed the title Upgrading isitio to v1.18.7 Upgrading istio to v1.18.7 Jun 3, 2024
@juliusvonkohout juliusvonkohout self-assigned this Jun 3, 2024
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@rimolive
Copy link
Member

rimolive commented Jun 3, 2024

I'm not sure if the TODO items are missing work items for this PR, but if the tests passed I think we're good to move on. I'll lgtm but will hold to merge until @juliusvonkohout approves.

/lgtm
/hold

@juliusvonkohout
Copy link
Member

TODO:

* Update istio-cni to 1.18.7 as well

* delete the istio 1.17 folders

* fix all tests

* Update the readme

* Transform the readme into a script as we have it in /hack to upgrade synchronize istio manifests in an automated manner next time

* For istio-cni we need a script as well

* use the script to update to in several PRs to 1.19, then 1.20, then 1.21 and 1.22 for istio and istio-cni

@biswajit-9776 lets continue this in a new PR then such that we can cut RC.1

@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

/unhold

@google-oss-prow google-oss-prow bot merged commit 3e742cc into kubeflow:master Jun 4, 2024
23 checks passed
juliusvonkohout pushed a commit that referenced this pull request Jun 4, 2024
* Upgrading isitio to v1.18.7

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Upgraded cni to v.1.18.7

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

---------

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@biswajit-9776 biswajit-9776 deleted the istio-1.18 branch June 5, 2024 11:11
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
* Upgrading isitio to v1.18.7

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Upgraded cni to v.1.18.7

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

---------

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants