Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update /models/ to /kserve-endpoints/ for kserve models web app … #2752

Merged

Conversation

OussemaLouati
Copy link
Contributor

Fix KServe model endpoints webapp Url.

Description

Update centraldashboard-config ConfigMap to point to the right link based on this VirtualService

Using /models/ will result in the following screen when deploying Kubeflow

models-invalid

After Updating the ConfigMap to use /kserve-endpoints/, the Models endpoint will show correctly:

kserve-fixed

Note: Instead of updating the ConfigMap centraldashboard-config we can update the actual VirtualService to use /models/ instead also.

…page to show

Signed-off-by: Oussema Louati <o.louati@cfp.energy>
@juliusvonkohout
Copy link
Member

It seems to have been changed in fb440d8

@diegolovison can you test whether it works in the current master branch ?

CC @rimolive

@juliusvonkohout
Copy link
Member

CC @kimwnasptd

@diegolovison
Copy link
Contributor

@diegolovison can you test whether it works in the current master branch ?

yes, I can but I have a question. Are we going to backport to 1.9 as well?

@juliusvonkohout
Copy link
Member

@diegolovison can you test whether it works in the current master branch ?

yes, I can but I have a question. Are we going to backport to 1.9 as well?

we have to get this into the next 1.9 RC for kubeflow/kubeflow.

@rimolive
Copy link
Member

/lgtm

I tested and it worked.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jun 18, 2024

/approve

tested by ricardo.

this is not the proper fix. It has to be fixed in kubeflow/kubeflow and it will hit us again on the next kubeflow/kubeflow synchronization. But for now we need to be able to release the next RC.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 70429ed into kubeflow:master Jun 18, 2024
4 checks passed
@juliusvonkohout
Copy link
Member

There is a PR to fix it kubeflow/kubeflow#7603

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants