-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update /models/ to /kserve-endpoints/ for kserve models web app … #2752
fix: update /models/ to /kserve-endpoints/ for kserve models web app … #2752
Conversation
…page to show Signed-off-by: Oussema Louati <o.louati@cfp.energy>
ee3d56a
to
98c1a38
Compare
It seems to have been changed in fb440d8 @diegolovison can you test whether it works in the current master branch ? CC @rimolive |
CC @kimwnasptd |
yes, I can but I have a question. Are we going to backport to 1.9 as well? |
we have to get this into the next 1.9 RC for kubeflow/kubeflow. |
/lgtm I tested and it worked. |
/approve tested by ricardo. this is not the proper fix. It has to be fixed in kubeflow/kubeflow and it will hit us again on the next kubeflow/kubeflow synchronization. But for now we need to be able to release the next RC. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is a PR to fix it kubeflow/kubeflow#7603 |
Fix KServe model endpoints webapp Url.
Description