Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce proper formatting on python ,bash and yaml files #2774

Merged
merged 37 commits into from
Jul 9, 2024
Merged

Introduce proper formatting on python ,bash and yaml files #2774

merged 37 commits into from
Jul 9, 2024

Commits on Jul 7, 2024

  1. Add balck github action to format python files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    590a0ee View commit details
    Browse the repository at this point in the history

  2. Formatted python files from the balck formatter 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    c929ea6 View commit details
    Browse the repository at this point in the history

  3. Add github action to format yaml files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    335393e View commit details
    Browse the repository at this point in the history

  4. Add step YAML Formatting Guidelines to yaml_formatter.yaml file 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    0388a29 View commit details
    Browse the repository at this point in the history

  5. made chnages to run next steps although the previous step fail 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    afbe930 View commit details
    Browse the repository at this point in the history

  6. switch steps 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    2c4db16 View commit details
    Browse the repository at this point in the history

  7. added shellCheck for bash formatting 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    fc0e758 View commit details
    Browse the repository at this point in the history

  8. Changed code only to lint yaml files inside the common and example fo… 

    …lder

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    43d95b8 View commit details
    Browse the repository at this point in the history

  9. Changed main to master 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    eb483c8 View commit details
    Browse the repository at this point in the history

  10. Run yamllint on files which is chnaged in PR only 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    5f6e20a View commit details
    Browse the repository at this point in the history

  11. Changed 'Proper formatting on python files' github workflow only to r… 

    …un for python files in common and example folder

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    18081cb View commit details
    Browse the repository at this point in the history

  12. Add shellcheckrc file 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    b132ba1 View commit details
    Browse the repository at this point in the history

  13. Disable SC1017,SC2086,SC2070 rules when shellcheck and did changes in… 

    … sh files to address the formattings according to shellcheck

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    672abc4 View commit details
    Browse the repository at this point in the history

  14. made chnages in sh files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    db19666 View commit details
    Browse the repository at this point in the history

  15. made chnages in sh files to address formattings 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    38a57d5 View commit details
    Browse the repository at this point in the history

  16. made chnages in sh files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    58ee8cd View commit details
    Browse the repository at this point in the history

  17. disable SC2046 rule 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    399e0a3 View commit details
    Browse the repository at this point in the history

  18. disable SC2006 and SC2155 rule 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    3c4c985 View commit details
    Browse the repository at this point in the history

  19. Change shellcheck only to run for PR chnaged files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    35b242f View commit details
    Browse the repository at this point in the history

  20. Address a issue with bash_formatter.yaml 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    bc5fd0b View commit details
    Browse the repository at this point in the history

  21. Changed origin/main to origin/master 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    cb67c39 View commit details
    Browse the repository at this point in the history

  22. Formatted python files from the balck formatter 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    77e2c25 View commit details
    Browse the repository at this point in the history

  23. Add github action to format yaml files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    8f252bb View commit details
    Browse the repository at this point in the history

  24. Add step YAML Formatting Guidelines to yaml_formatter.yaml file 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    045b504 View commit details
    Browse the repository at this point in the history

  25. made chnages to run next steps although the previous step fail 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    19881d4 View commit details
    Browse the repository at this point in the history

  26. switch steps 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    04e1858 View commit details
    Browse the repository at this point in the history

  27. Add shellcheckrc file 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    8ee988d View commit details
    Browse the repository at this point in the history

  28. Disable SC1017,SC2086,SC2070 rules when shellcheck and did changes in… 

    … sh files to address the formattings according to shellcheck

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    0f27d46 View commit details
    Browse the repository at this point in the history

  29. made chnages in sh files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    5e5e4c4 View commit details
    Browse the repository at this point in the history

  30. Change shellcheck only to run for PR chnaged files 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    859ced5 View commit details
    Browse the repository at this point in the history

  31. Ensure the full history is fetched 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    107db8e View commit details
    Browse the repository at this point in the history

  32. Ensure the full history is fetched in bash_formatter 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    64bd2d9 View commit details
    Browse the repository at this point in the history

  33. fix SC2148 (error) 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    0226a0e View commit details
    Browse the repository at this point in the history

  34. remove commented lines in bash_formatter.yaml 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    a4bc63f View commit details
    Browse the repository at this point in the history

  35. remove formatting chnages done to app folder content 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    2730efc View commit details
    Browse the repository at this point in the history

  36. Add guidlines to how to format python files according to black formatter 

    Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    5e7dfb5 View commit details
    Browse the repository at this point in the history

  37. Add guidlines to how to format bash files according to shellcheck for… 

    …matter

Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
    @hansinikarunarathne
    hansinikarunarathne committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    9ae743f View commit details
    Browse the repository at this point in the history