-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the pull request template #2793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least
Checklist
- I have installed kustomize == 5.2.1+
- All the commits have been signed-off (To pass the
DCO
check)
shall stay, since this is useful information for new contributors.
It is under the test suite's responsibility and also https://github.com/kubeflow/manifests#prerequisites
Maybe we should instead of having a checking |
I just saw that this PR failed the DCO. |
Then please link to the main readme
in some way |
Done. What do you think? |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Simplify the pull request template Signed-off-by: Diego Lovison <diegolovison@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Simplify the pull request template Signed-off-by: Diego Lovison <diegolovison@gmail.com> Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
follow-up to kubeflow#2793 - add link to sign-off/DCO - CLA no longer required Signed-off-by: tarilabs <matteo.mortari@gmail.com>
* update PR template follow-up to #2793 - add link to sign-off/DCO - CLA no longer required Signed-off-by: tarilabs <matteo.mortari@gmail.com> * update DCO link to one in KF community Signed-off-by: tarilabs <matteo.mortari@gmail.com> --------- Signed-off-by: tarilabs <matteo.mortari@gmail.com>
* update PR template follow-up to kubeflow#2793 - add link to sign-off/DCO - CLA no longer required Signed-off-by: tarilabs <matteo.mortari@gmail.com> * update DCO link to one in KF community Signed-off-by: tarilabs <matteo.mortari@gmail.com> --------- Signed-off-by: tarilabs <matteo.mortari@gmail.com> Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Unit Test Checklist and Contributor checklist are done automatically
A brief description of the changes is a duplicated of Please include a summary of changes and the related issue.