Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the pull request template #2793

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Jul 9, 2024

Unit Test Checklist and Contributor checklist are done automatically
A brief description of the changes is a duplicated of Please include a summary of changes and the related issue.

Copy link
Member

@juliusvonkohout juliusvonkohout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least

Checklist

  • I have installed kustomize == 5.2.1+
  • All the commits have been signed-off (To pass the DCO check)

shall stay, since this is useful information for new contributors.

@diegolovison
Copy link
Contributor Author

I have installed kustomize == 5.2.1+

It is under the test suite's responsibility and also https://github.com/kubeflow/manifests#prerequisites

All the commits have been signed-off (To pass the DCO check)

Maybe we should instead of having a checking [ ] change to something like an information?

@diegolovison
Copy link
Contributor Author

I just saw that this PR failed the DCO.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jul 9, 2024

I have installed kustomize == 5.2.1+

It is under the test suite's responsibility and also https://github.com/kubeflow/manifests#prerequisites

All the commits have been signed-off (To pass the DCO check)

Maybe we should instead of having a checking [ ] change to something like an information?

Then please link to the main readme

in some way

@diegolovison
Copy link
Contributor Author

Done. What do you think?

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

Simplify the pull request template

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8e4fafb into kubeflow:master Jul 10, 2024
6 checks passed
hansinikarunarathne pushed a commit to hansinikarunarathne/kubeflow-manifests that referenced this pull request Jul 22, 2024
Simplify the pull request template

Signed-off-by: Diego Lovison <diegolovison@gmail.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
tarilabs added a commit to tarilabs/kubeflow-manifests that referenced this pull request Aug 27, 2024
follow-up to kubeflow#2793
- add link to sign-off/DCO
- CLA no longer required

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
@tarilabs tarilabs mentioned this pull request Aug 27, 2024
google-oss-prow bot pushed a commit that referenced this pull request Aug 28, 2024
* update PR template

follow-up to #2793
- add link to sign-off/DCO
- CLA no longer required

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* update DCO link to one in KF community

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

---------

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
* update PR template

follow-up to kubeflow#2793
- add link to sign-off/DCO
- CLA no longer required

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* update DCO link to one in KF community

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

---------

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants