Proper message display when no bash, python and YAML files changed in the PR #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansinikarunarathne
force-pushed
the
fix_requested_changes_in_linting
branch
6 times, most recently
from
9dd2962
to
2382e5a
Compare
hansinikarunarathne
changed the title
hansinikarunarathne
force-pushed
the
fix_requested_changes_in_linting
branch
from
1497032
to
5abd862
Compare
|
You have to fix the DCO before i can merge. |
hansinikarunarathne
force-pushed
the
fix_requested_changes_in_linting
branch
from
dc14a4a
to
1d444b2
Compare
juliusvonkohout
changed the title
There was a problem hiding this comment.
Why are you changing this file?
There was a problem hiding this comment.
Why are you changing this file?
There was a problem hiding this comment.
The difference is showed in the same line. But I did not change it.
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com>
hansinikarunarathne
force-pushed
the
fix_requested_changes_in_linting
branch
from
1a5c430
to
480b0ef
Compare
7 tasks
|
/lgtm we need to see it in action |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pschoen-itsc
pushed a commit
to pschoen-itsc/kf-manifests
that referenced
this pull request
Sep 3, 2024
… the PR (kubeflow#2803) * Proper message display when no bash files chnaged in the PR Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Proper message display when no Yaml files chnaged in the PR Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Proper message display when no Yaml files chnaged and styled in the PR Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Proper message display when no need to do style in Yaml files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Check the linting working by changing a yaml file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Testing working of Bash linting Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Make some fix in formatting bash files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * checking functionalities of linting Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Combined Yaml,Bash and Python formatting yaml files into one workflow Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Deleted seperate files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Check the linting working by changing a yaml file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Testing working of Bash linting Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * fix the mistake of changing unwanted file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --------- Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCOcheck)cla/googlecheck)