From 4ab31d7baa9cde42301ca799993af40b1e162f46 Mon Sep 17 00:00:00 2001 From: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> Date: Fri, 26 Jul 2024 15:56:55 +0200 Subject: [PATCH 01/28] Training operator CICD improvements (#2779) * Add the networkpolicies Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * rework the training operator tests Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix the comments Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix filename Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * try to fix the permissions Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * try to fix the permissions Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * change to the user namespace Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update the image to rc.1 Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fixes Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/training_operator_test.yaml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/training_operator_test.yaml b/.github/workflows/training_operator_test.yaml index e9b107beb..5be7d5dff 100644 --- a/.github/workflows/training_operator_test.yaml +++ b/.github/workflows/training_operator_test.yaml @@ -2,14 +2,14 @@ name: Build & Apply Training Operator manifests in KinD on: pull_request: paths: - - .github/workflows/training_operator_test.yaml - - apps/training-operator/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** - - tests/gh-actions/kf-objects/tfjob.yaml + - .github/workflows/training_operator_test.yaml + - apps/training-operator/upstream/** + - tests/gh-actions/kind-cluster.yaml + - tests/gh-actions/install_kind.sh + - tests/gh-actions/install_kustomize.sh + - tests/gh-actions/install_istio.sh + - common/istio*/** + - tests/gh-actions/kf-objects/tfjob.yaml jobs: build: From 53d6930bfa27b976fa717257e138d51dd918c234 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Mon, 22 Jul 2024 11:12:17 +0530 Subject: [PATCH 02/28] create seperate file for install_KinD_create_KinD_cluster_install_kustomize.sh to avoid code repitition Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/admission_webhook_test.yaml | 24 +++++---------- ...D_create_KinD_cluster_install_kustomize.sh | 29 +++++++++++++++++++ 2 files changed, 37 insertions(+), 16 deletions(-) create mode 100644 tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml index 2660a70e7..6d55a6ddc 100644 --- a/.github/workflows/admission_webhook_test.yaml +++ b/.github/workflows/admission_webhook_test.yaml @@ -2,14 +2,12 @@ name: Build & Apply PodDefaults manifests in KinD on: pull_request: paths: - - .github/workflows/admission_webhook_test.yaml - - apps/admission-webhook/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** + - .github/workflows/admission_webhook_test.yaml + - apps/admission-webhook/upstream/** + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** jobs: build: @@ -18,14 +16,8 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh new file mode 100644 index 000000000..81f5e559c --- /dev/null +++ b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh @@ -0,0 +1,29 @@ +#!/bin/bash + +set -e + +# Function to handle errors +handle_error() { + echo "Error: $1" + exit 1 +} + +# Install KinD +echo "Installing KinD..." +if ! ./tests/gh-actions/install_kind.sh; then + handle_error "Failed to install KinD" +fi + +# Create KinD Cluster +echo "Creating KinD Cluster..." +if ! kind create cluster --config tests/gh-actions/kind-cluster.yaml; then + handle_error "Failed to create KinD cluster" +fi + +# Install kustomize +echo "Installing kustomize..." +if ! ./tests/gh-actions/install_kustomize.sh; then + handle_error "Failed to install kustomize" +fi + +echo "All steps completed successfully." From 10db369b4e4fdb292befad6867f69b7a9ff4ce0c Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Mon, 22 Jul 2024 11:21:29 +0530 Subject: [PATCH 03/28] make sh file executable Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/admission_webhook_test.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml index 6d55a6ddc..9dcfe3da8 100644 --- a/.github/workflows/admission_webhook_test.yaml +++ b/.github/workflows/admission_webhook_test.yaml @@ -17,7 +17,9 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh From 75655d362e17eb278317965bcd4580780324be40 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 15:32:38 +0530 Subject: [PATCH 04/28] remove reduntant codes Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/bentoml_test.yaml | 14 +++---- .github/workflows/centraldashboard_test.yaml | 21 ++++------ .github/workflows/dex_test.yaml | 21 ++++------ .../jupyter_web_application_test.yaml | 21 ++++------ .github/workflows/katib_test.yaml | 25 +++++------- .github/workflows/kserve_cni_test.yaml | 29 ++++++-------- .github/workflows/kserve_m2m_test.yaml | 39 ++++++++----------- .github/workflows/kserve_test.yaml | 29 ++++++-------- .github/workflows/metacontroller_test.yaml | 27 +++++-------- .github/workflows/model_registry_test.yaml | 20 ++++------ .../notebook_controller_m2m_test.yaml | 27 +++++-------- .../workflows/notebook_controller_test.yaml | 23 ++++------- .../workflows/pipeline_run_from_notebook.yaml | 35 +++++++---------- .github/workflows/pipeline_test.yaml | 31 ++++++--------- .github/workflows/profiles_test.yaml | 23 ++++------- .github/workflows/ray_test.yaml | 20 ++++------ .github/workflows/seldon_test.yaml | 27 +++++-------- .../tensorboard_controller_test.yaml | 23 ++++------- .../tensorboards_web_application_test.yaml | 23 ++++------- .github/workflows/training_operator_test.yaml | 15 ++----- .../volumes_web_application_test.yaml | 23 ++++------- 21 files changed, 187 insertions(+), 329 deletions(-) diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index 41a8fc276..18a9afc67 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -17,15 +17,11 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh - + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - name: Install cert-manager run: ./tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml index f5373d127..691d13a6a 100644 --- a/.github/workflows/centraldashboard_test.yaml +++ b/.github/workflows/centraldashboard_test.yaml @@ -2,12 +2,9 @@ name: Build & Apply CentralDashboard manifests in KinD on: pull_request: paths: - - .github/workflows/centraldashboard_test.yaml - - apps/centraldashboard/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh + - .github/workflows/centraldashboard_test.yaml + - apps/centraldashboard/upstream/** + - tests/gh-actions/install_istio.sh jobs: build: @@ -16,14 +13,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml index 84ffecea3..70b7b3614 100644 --- a/.github/workflows/dex_test.yaml +++ b/.github/workflows/dex_test.yaml @@ -2,12 +2,9 @@ name: Build & Apply Dex manifests in KinD on: pull_request: paths: - - .github/workflows/dex_test.yaml - - common/dex/base/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh + - .github/workflows/dex_test.yaml + - common/dex/base/** + - tests/gh-actions/install_istio.sh jobs: build: @@ -16,14 +13,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml index 13715e174..f01d5c717 100644 --- a/.github/workflows/jupyter_web_application_test.yaml +++ b/.github/workflows/jupyter_web_application_test.yaml @@ -2,12 +2,9 @@ name: Build & Apply JWA manifests in KinD on: pull_request: paths: - - .github/workflows/jupyter_web_application_test.yaml - - apps/jupyter/jupyter-web-app/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh + - .github/workflows/jupyter_web_application_test.yaml + - apps/jupyter/jupyter-web-app/upstream/** + - tests/gh-actions/install_istio.sh jobs: build: @@ -16,14 +13,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index 9edace0aa..299b768da 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -2,14 +2,11 @@ name: Build & Apply Katib manifests in KinD on: pull_request: paths: - - .github/workflows/katib_test.yaml - - apps/katib/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** + - .github/workflows/katib_test.yaml + - apps/katib/upstream/** + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** jobs: build: @@ -18,14 +15,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/kserve_cni_test.yaml b/.github/workflows/kserve_cni_test.yaml index c9ac27229..a75b65ae9 100644 --- a/.github/workflows/kserve_cni_test.yaml +++ b/.github/workflows/kserve_cni_test.yaml @@ -2,16 +2,13 @@ name: Build & Apply KServe manifests in KinD, using istio CNI on: pull_request: paths: - - .github/workflows/kserve_cni_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - common/istio-cni-1-22/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_knative-cni.sh - - common/knative/** - - tests/gh-actions/install_kserve.sh + - .github/workflows/kserve_cni_test.yaml + - common/istio-cni-1-22/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_knative-cni.sh + - common/knative/** + - tests/gh-actions/install_kserve.sh jobs: build: @@ -20,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/kserve_m2m_test.yaml b/.github/workflows/kserve_m2m_test.yaml index b468702f1..a398ec3e6 100644 --- a/.github/workflows/kserve_m2m_test.yaml +++ b/.github/workflows/kserve_m2m_test.yaml @@ -2,19 +2,16 @@ name: Deploy and test KServe with m2m auth in KinD on: pull_request: paths: - - .github/workflows/kserve_m2m_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - contrib/kserve/** - - common/oauth2-proxy/** - - common/istio*/** - - tests/gh-actions/install_istio_with_ext_auth.sh* - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_knative.sh - - common/knative/** - - tests/gh-actions/install_kserve.sh + - .github/workflows/kserve_m2m_test.yaml + - contrib/kserve/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - tests/gh-actions/install_istio_with_ext_auth.sh* + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_knative.sh + - common/knative/** + - tests/gh-actions/install_kserve.sh jobs: build: @@ -23,20 +20,16 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh - - - name: Create kubeflow namespace - run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - + - name: Create kubeflow namespace + run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - - name: Install Istio with external authentication run: ./tests/gh-actions/install_istio_with_ext_auth.sh diff --git a/.github/workflows/kserve_test.yaml b/.github/workflows/kserve_test.yaml index 81b982511..82bf97211 100644 --- a/.github/workflows/kserve_test.yaml +++ b/.github/workflows/kserve_test.yaml @@ -2,16 +2,13 @@ name: Build & Apply KServe manifests in KinD on: pull_request: paths: - - .github/workflows/kserve_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - contrib/kserve/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_knative.sh - - common/knative/** - - tests/gh-actions/install_kserve.sh + - .github/workflows/kserve_test.yaml + - contrib/kserve/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_knative.sh + - common/knative/** + - tests/gh-actions/install_kserve.sh jobs: build: @@ -20,14 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/metacontroller_test.yaml b/.github/workflows/metacontroller_test.yaml index 987d30cd7..0d1153636 100644 --- a/.github/workflows/metacontroller_test.yaml +++ b/.github/workflows/metacontroller_test.yaml @@ -2,15 +2,12 @@ name: Build & Apply contrib/metacontroller in KinD on: pull_request: paths: - - .github/workflows/metacontroller_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - contrib/metacontroller/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/metacontroller_test.yaml + - contrib/metacontroller/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: @@ -19,14 +16,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config ./tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/model_registry_test.yaml b/.github/workflows/model_registry_test.yaml index e3c59aa6c..b3e8f6eff 100644 --- a/.github/workflows/model_registry_test.yaml +++ b/.github/workflows/model_registry_test.yaml @@ -4,11 +4,9 @@ name: Deploy and test Kubeflow Model Registry on: pull_request: paths: - - apps/model-registry/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** + - apps/model-registry/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build-kfmr: @@ -17,18 +15,14 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh - - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/notebook_controller_m2m_test.yaml b/.github/workflows/notebook_controller_m2m_test.yaml index fa0f70a93..dd66bb76d 100644 --- a/.github/workflows/notebook_controller_m2m_test.yaml +++ b/.github/workflows/notebook_controller_m2m_test.yaml @@ -2,15 +2,12 @@ name: Test Notebook Controller with m2m auth manifests in KinD on: pull_request: paths: - - .github/workflows/notebook_controller_m2m_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - apps/jupyter/** - - common/oauth2-proxy/** - - common/istio*/** - - tests/gh-actions/install_istio_with_ext_auth.sh* - - tests/gh-actions/install_multi_tenancy.sh + - .github/workflows/notebook_controller_m2m_test.yaml + - apps/jupyter/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - tests/gh-actions/install_istio_with_ext_auth.sh* + - tests/gh-actions/install_multi_tenancy.sh jobs: build: @@ -19,18 +16,14 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh - - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/notebook_controller_test.yaml b/.github/workflows/notebook_controller_test.yaml index a423f0545..6573f8f79 100644 --- a/.github/workflows/notebook_controller_test.yaml +++ b/.github/workflows/notebook_controller_test.yaml @@ -2,13 +2,10 @@ name: Build & Apply Notebook Controller manifests in KinD on: pull_request: paths: - - .github/workflows/notebook_controller_test.yaml - - apps/jupyter/notebook-controller/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/notebook_controller_test.yaml + - apps/jupyter/notebook-controller/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: @@ -17,14 +14,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 7d91966ad..98e6e08d2 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -2,19 +2,16 @@ name: Create Pipeline Run from Kubeflow Notebook on: pull_request: paths: - - .github/workflows/pipeline_run_from_notebook.yaml - - apps/jupyter/notebook-controller/upstream/** - - apps/pipeline/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - common/oauth2-proxy/** - - common/istio*/** - - common//** - - apps/jupyter/** + - .github/workflows/pipeline_run_from_notebook.yaml + - apps/jupyter/notebook-controller/upstream/** + - apps/pipeline/upstream/** + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - common/oidc-client/** + - apps/jupyter/** jobs: build: @@ -23,14 +20,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio with external authentication run: ./tests/gh-actions/install_istio_with_ext_auth.sh diff --git a/.github/workflows/pipeline_test.yaml b/.github/workflows/pipeline_test.yaml index 2cfcca0cf..f1c44dac6 100644 --- a/.github/workflows/pipeline_test.yaml +++ b/.github/workflows/pipeline_test.yaml @@ -2,17 +2,14 @@ name: Deploy and test Kubeflow Pipelines manifests with m2m auth in KinD on: pull_request: paths: - - .github/workflows/pipeline_test.yaml - - apps/pipeline/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - common/oauth2-proxy/** - - common/istio*/** - - tests/gh-actions/install_istio_with_ext_auth.sh + - .github/workflows/pipeline_test.yaml + - apps/pipeline/upstream/** + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - tests/gh-actions/install_istio_with_ext_auth.sh jobs: build: @@ -21,14 +18,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/profiles_test.yaml b/.github/workflows/profiles_test.yaml index d562ff7c0..caaedac95 100644 --- a/.github/workflows/profiles_test.yaml +++ b/.github/workflows/profiles_test.yaml @@ -2,13 +2,10 @@ name: Build & Apply Profiles manifests in KinD on: pull_request: paths: - - .github/workflows/profiles_test.yaml - - apps/profiles/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/profiles_test.yaml + - apps/profiles/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: @@ -17,14 +14,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/ray_test.yaml b/.github/workflows/ray_test.yaml index d726105e8..20fb858d5 100644 --- a/.github/workflows/ray_test.yaml +++ b/.github/workflows/ray_test.yaml @@ -2,10 +2,8 @@ name: Build & Apply Ray manifest in KinD on: pull_request: paths: - - .github/workflows/ray_test.yaml - - contrib/ray/** - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh + - .github/workflows/ray_test.yaml + - contrib/ray/** jobs: build: @@ -13,15 +11,11 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Build & Apply manifests run: | diff --git a/.github/workflows/seldon_test.yaml b/.github/workflows/seldon_test.yaml index c98b8be44..4688256e8 100644 --- a/.github/workflows/seldon_test.yaml +++ b/.github/workflows/seldon_test.yaml @@ -2,15 +2,12 @@ name: Build & Apply Seldon manifests in KinD on: pull_request: paths: - - .github/workflows/seldon_test.yaml - - tests/gh-actions/kind-cluster.yaml - - contrib/seldon/** - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** + - .github/workflows/seldon_test.yaml + - contrib/seldon/** + - tests/gh-actions/install_istio.sh + - common/istio*/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** jobs: build: @@ -19,14 +16,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboard_controller_test.yaml b/.github/workflows/tensorboard_controller_test.yaml index 69c044db9..94e5e0a53 100644 --- a/.github/workflows/tensorboard_controller_test.yaml +++ b/.github/workflows/tensorboard_controller_test.yaml @@ -2,13 +2,10 @@ name: Build & Apply Tensorboard Controller manifests in KinD on: pull_request: paths: - - .github/workflows/tensorboard_controller_test.yaml - - apps/tensorboard/tensorboard-controller/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/tensorboard_controller_test.yaml + - apps/tensorboard/tensorboard-controller/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: @@ -17,14 +14,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboards_web_application_test.yaml b/.github/workflows/tensorboards_web_application_test.yaml index a0072655d..5c24d8129 100644 --- a/.github/workflows/tensorboards_web_application_test.yaml +++ b/.github/workflows/tensorboards_web_application_test.yaml @@ -2,13 +2,10 @@ name: Build & Apply TWA manifests in KinD on: pull_request: paths: - - .github/workflows/tensorboards_web_application_test.yaml - - apps/tensorboard/tensorboards-web-app/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/tensorboards_web_application_test.yaml + - apps/tensorboard/tensorboards-web-app/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: @@ -17,14 +14,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/training_operator_test.yaml b/.github/workflows/training_operator_test.yaml index 5be7d5dff..d386e124e 100644 --- a/.github/workflows/training_operator_test.yaml +++ b/.github/workflows/training_operator_test.yaml @@ -4,9 +4,6 @@ on: paths: - .github/workflows/training_operator_test.yaml - apps/training-operator/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - tests/gh-actions/install_istio.sh - common/istio*/** - tests/gh-actions/kf-objects/tfjob.yaml @@ -18,14 +15,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/volumes_web_application_test.yaml b/.github/workflows/volumes_web_application_test.yaml index 4165b90fa..c2a8d0f4f 100644 --- a/.github/workflows/volumes_web_application_test.yaml +++ b/.github/workflows/volumes_web_application_test.yaml @@ -2,13 +2,10 @@ name: Build & Apply VWA manifests in KinD on: pull_request: paths: - - .github/workflows/volumes_web_application_test.yaml - - apps/volumes-web-app/upstream/** - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/volumes_web_application_test.yaml + - apps/volumes-web-app/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: @@ -17,14 +14,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh From 735cff736b20729970724f81f87c0c60927fea6a Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 20:53:30 +0530 Subject: [PATCH 05/28] combine kind, kuztomize and kind-cluster create sh files into one file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/bentoml_test.yaml | 11 +-- ...D_create_KinD_cluster_install_kustomize.sh | 74 ++++++++++++++----- 2 files changed, 59 insertions(+), 26 deletions(-) diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index 18a9afc67..c0a05884c 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -2,13 +2,10 @@ name: Build & Apply BentoML Yatai Stack manifests in KinD on: pull_request: paths: - - .github/workflows/bentoml_test.yaml - - tests/gh-actions/kind-cluster.yaml - - tests/gh-actions/install_kind.sh - - tests/gh-actions/install_kustomize.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - contrib/bentoml/** + - .github/workflows/bentoml_test.yaml + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - contrib/bentoml/** jobs: build: diff --git a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh index 81f5e559c..38965f664 100644 --- a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh +++ b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh @@ -1,29 +1,65 @@ #!/bin/bash - set -e -# Function to handle errors -handle_error() { - echo "Error: $1" +error_exit() { + echo "Error occurred in script at line: ${1}." exit 1 } -# Install KinD -echo "Installing KinD..." -if ! ./tests/gh-actions/install_kind.sh; then - handle_error "Failed to install KinD" -fi +trap 'error_exit $LINENO' ERR -# Create KinD Cluster -echo "Creating KinD Cluster..." -if ! kind create cluster --config tests/gh-actions/kind-cluster.yaml; then - handle_error "Failed to create KinD cluster" -fi +echo "Fetching KinD executable ..." +sudo swapoff -a -# Install kustomize -echo "Installing kustomize..." -if ! ./tests/gh-actions/install_kustomize.sh; then - handle_error "Failed to install kustomize" +# This conditional helps running GH Workflows through +# [act](https://github.com/nektos/act) +if [ -e /swapfile ]; then + sudo rm -f /swapfile + sudo mkdir -p /tmp/etcd + sudo mount -t tmpfs tmpfs /tmp/etcd fi -echo "All steps completed successfully." +{ + curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.20.0/kind-linux-amd64 + chmod +x ./kind + sudo mv kind /usr/local/bin +} || { echo "Failed to install KinD"; exit 1; } + +echo "Fetching Kustomize ..." +{ + curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_amd64.tar.gz" + tar -xzvf kustomize_v5.2.1_linux_amd64.tar.gz + chmod a+x kustomize + sudo mv kustomize /usr/local/bin/kustomize +} || { echo "Failed to install Kustomize"; exit 1; } + +cat < kind-config.yaml +apiVersion: kind.x-k8s.io/v1alpha4 +kind: Cluster +# Configure registry for KinD. +containerdConfigPatches: +- |- + [plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"] + endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"] +# This is needed in order to support projected volumes with service account tokens. +# See: https://kubernetes.slack.com/archives/CEKK1KTN2/p1600268272383600 +kubeadmConfigPatches: + - | + apiVersion: kubeadm.k8s.io/v1beta2 + kind: ClusterConfiguration + metadata: + name: config + apiServer: + extraArgs: + "service-account-issuer": "kubernetes.default.svc" + "service-account-signing-key-file": "/etc/kubernetes/pki/sa.key" +nodes: +- role: control-plane + image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 +- role: worker + image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 +- role: worker + image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 +EOF + +echo "KinD and Kustomize have been installed and the KinD configuration has been created in 'kind-config.yaml'." From ea8c4eda6a5f146b91368673e0f0e451d9aa294c Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 21:07:14 +0530 Subject: [PATCH 06/28] fix issues with combined file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- ...D_create_KinD_cluster_install_kustomize.sh | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh index 38965f664..cd40b5b99 100644 --- a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh +++ b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh @@ -8,7 +8,7 @@ error_exit() { trap 'error_exit $LINENO' ERR -echo "Fetching KinD executable ..." +echo "Install KinD..." sudo swapoff -a # This conditional helps running GH Workflows through @@ -25,15 +25,9 @@ fi sudo mv kind /usr/local/bin } || { echo "Failed to install KinD"; exit 1; } -echo "Fetching Kustomize ..." -{ - curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_amd64.tar.gz" - tar -xzvf kustomize_v5.2.1_linux_amd64.tar.gz - chmod a+x kustomize - sudo mv kustomize /usr/local/bin/kustomize -} || { echo "Failed to install Kustomize"; exit 1; } -cat < kind-config.yaml +echo "Creating KinD cluster ..." +echo " apiVersion: kind.x-k8s.io/v1alpha4 kind: Cluster # Configure registry for KinD. @@ -60,6 +54,13 @@ nodes: image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 - role: worker image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 -EOF +" | kind create cluster --config - + -echo "KinD and Kustomize have been installed and the KinD configuration has been created in 'kind-config.yaml'." +echo "Install Kustomize ..." +{ + curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_amd64.tar.gz" + tar -xzvf kustomize_v5.2.1_linux_amd64.tar.gz + chmod a+x kustomize + sudo mv kustomize /usr/local/bin/kustomize +} || { echo "Failed to install Kustomize"; exit 1; } \ No newline at end of file From 425b0a43ca5d4d1354adf43c0d2a8af20961a3f7 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 21:13:49 +0530 Subject: [PATCH 07/28] fix configurations issues Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- ...stall_KinD_create_KinD_cluster_install_kustomize.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh index cd40b5b99..37e80d0fd 100644 --- a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh +++ b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh @@ -33,8 +33,8 @@ kind: Cluster # Configure registry for KinD. containerdConfigPatches: - |- - [plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"] - endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"] + [plugins.\"io.containerd.grpc.v1.cri\".registry.mirrors.\"$REGISTRY_NAME:$REGISTRY_PORT\"] + endpoint = [\"http://$REGISTRY_NAME:$REGISTRY_PORT\"] # This is needed in order to support projected volumes with service account tokens. # See: https://kubernetes.slack.com/archives/CEKK1KTN2/p1600268272383600 kubeadmConfigPatches: @@ -45,8 +45,8 @@ kubeadmConfigPatches: name: config apiServer: extraArgs: - "service-account-issuer": "kubernetes.default.svc" - "service-account-signing-key-file": "/etc/kubernetes/pki/sa.key" + \"service-account-issuer\": \"kubernetes.default.svc\" + \"service-account-signing-key-file\": \"/etc/kubernetes/pki/sa.key\" nodes: - role: control-plane image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 @@ -63,4 +63,4 @@ echo "Install Kustomize ..." tar -xzvf kustomize_v5.2.1_linux_amd64.tar.gz chmod a+x kustomize sudo mv kustomize /usr/local/bin/kustomize -} || { echo "Failed to install Kustomize"; exit 1; } \ No newline at end of file +} || { echo "Failed to install Kustomize"; exit 1; } From 6542c4cbd9bc36bc4bcea3c0ed408722a6ef919c Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 21:36:30 +0530 Subject: [PATCH 08/28] fix linting issues in workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/admission_webhook_test.yaml | 12 +++---- .github/workflows/bentoml_test.yaml | 10 +++--- .github/workflows/centraldashboard_test.yaml | 6 ++-- .github/workflows/dex_test.yaml | 6 ++-- .../jupyter_web_application_test.yaml | 6 ++-- .github/workflows/katib_test.yaml | 10 +++--- .github/workflows/kserve_cni_test.yaml | 22 ++++++------- .github/workflows/kserve_m2m_test.yaml | 32 +++++++++---------- .github/workflows/kserve_test.yaml | 22 ++++++------- .github/workflows/metacontroller_test.yaml | 12 +++---- .github/workflows/model_registry_test.yaml | 6 ++-- .../notebook_controller_m2m_test.yaml | 12 +++---- .../workflows/notebook_controller_test.yaml | 8 ++--- .../workflows/pipeline_run_from_notebook.yaml | 20 ++++++------ .github/workflows/pipeline_test.yaml | 16 +++++----- .github/workflows/profiles_test.yaml | 8 ++--- .github/workflows/ray_test.yaml | 6 ++-- .github/workflows/seldon_test.yaml | 12 +++---- .../tensorboard_controller_test.yaml | 8 ++--- .../tensorboards_web_application_test.yaml | 8 ++--- .github/workflows/training_operator_test.yaml | 10 +++--- .../volumes_web_application_test.yaml | 8 ++--- 22 files changed, 130 insertions(+), 130 deletions(-) diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml index 9dcfe3da8..723abbcb8 100644 --- a/.github/workflows/admission_webhook_test.yaml +++ b/.github/workflows/admission_webhook_test.yaml @@ -2,12 +2,12 @@ name: Build & Apply PodDefaults manifests in KinD on: pull_request: paths: - - .github/workflows/admission_webhook_test.yaml - - apps/admission-webhook/upstream/** - - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** + - .github/workflows/admission_webhook_test.yaml + - apps/admission-webhook/upstream/** + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** jobs: build: diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index c0a05884c..ab29d4689 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -2,10 +2,10 @@ name: Build & Apply BentoML Yatai Stack manifests in KinD on: pull_request: paths: - - .github/workflows/bentoml_test.yaml - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - contrib/bentoml/** + - .github/workflows/bentoml_test.yaml + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - contrib/bentoml/** jobs: build: @@ -18,7 +18,7 @@ jobs: run: | chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - + - name: Install cert-manager run: ./tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml index 691d13a6a..244c54619 100644 --- a/.github/workflows/centraldashboard_test.yaml +++ b/.github/workflows/centraldashboard_test.yaml @@ -2,9 +2,9 @@ name: Build & Apply CentralDashboard manifests in KinD on: pull_request: paths: - - .github/workflows/centraldashboard_test.yaml - - apps/centraldashboard/upstream/** - - tests/gh-actions/install_istio.sh + - .github/workflows/centraldashboard_test.yaml + - apps/centraldashboard/upstream/** + - tests/gh-actions/install_istio.sh jobs: build: diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml index 70b7b3614..c9276b5f9 100644 --- a/.github/workflows/dex_test.yaml +++ b/.github/workflows/dex_test.yaml @@ -2,9 +2,9 @@ name: Build & Apply Dex manifests in KinD on: pull_request: paths: - - .github/workflows/dex_test.yaml - - common/dex/base/** - - tests/gh-actions/install_istio.sh + - .github/workflows/dex_test.yaml + - common/dex/base/** + - tests/gh-actions/install_istio.sh jobs: build: diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml index f01d5c717..19723ed4d 100644 --- a/.github/workflows/jupyter_web_application_test.yaml +++ b/.github/workflows/jupyter_web_application_test.yaml @@ -2,9 +2,9 @@ name: Build & Apply JWA manifests in KinD on: pull_request: paths: - - .github/workflows/jupyter_web_application_test.yaml - - apps/jupyter/jupyter-web-app/upstream/** - - tests/gh-actions/install_istio.sh + - .github/workflows/jupyter_web_application_test.yaml + - apps/jupyter/jupyter-web-app/upstream/** + - tests/gh-actions/install_istio.sh jobs: build: diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index 299b768da..0d354601f 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -2,11 +2,11 @@ name: Build & Apply Katib manifests in KinD on: pull_request: paths: - - .github/workflows/katib_test.yaml - - apps/katib/upstream/** - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** + - .github/workflows/katib_test.yaml + - apps/katib/upstream/** + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** jobs: build: diff --git a/.github/workflows/kserve_cni_test.yaml b/.github/workflows/kserve_cni_test.yaml index a75b65ae9..d0fe52d29 100644 --- a/.github/workflows/kserve_cni_test.yaml +++ b/.github/workflows/kserve_cni_test.yaml @@ -2,13 +2,13 @@ name: Build & Apply KServe manifests in KinD, using istio CNI on: pull_request: paths: - - .github/workflows/kserve_cni_test.yaml - - common/istio-cni-1-22/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_knative-cni.sh - - common/knative/** - - tests/gh-actions/install_kserve.sh + - .github/workflows/kserve_cni_test.yaml + - common/istio-cni-1-22/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_knative-cni.sh + - common/knative/** + - tests/gh-actions/install_kserve.sh jobs: build: @@ -17,10 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/kserve_m2m_test.yaml b/.github/workflows/kserve_m2m_test.yaml index a398ec3e6..1bd46c9ae 100644 --- a/.github/workflows/kserve_m2m_test.yaml +++ b/.github/workflows/kserve_m2m_test.yaml @@ -2,16 +2,16 @@ name: Deploy and test KServe with m2m auth in KinD on: pull_request: paths: - - .github/workflows/kserve_m2m_test.yaml - - contrib/kserve/** - - common/oidc-client/oauth2-proxy/** - - common/istio*/** - - tests/gh-actions/install_istio_with_ext_auth.sh* - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_knative.sh - - common/knative/** - - tests/gh-actions/install_kserve.sh + - .github/workflows/kserve_m2m_test.yaml + - contrib/kserve/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - tests/gh-actions/install_istio_with_ext_auth.sh* + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_knative.sh + - common/knative/** + - tests/gh-actions/install_kserve.sh jobs: build: @@ -20,16 +20,16 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh - - name: Create kubeflow namespace - run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - + - name: Create kubeflow namespace + run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - - name: Install Istio with external authentication run: ./tests/gh-actions/install_istio_with_ext_auth.sh diff --git a/.github/workflows/kserve_test.yaml b/.github/workflows/kserve_test.yaml index 82bf97211..a214a5b7e 100644 --- a/.github/workflows/kserve_test.yaml +++ b/.github/workflows/kserve_test.yaml @@ -2,13 +2,13 @@ name: Build & Apply KServe manifests in KinD on: pull_request: paths: - - .github/workflows/kserve_test.yaml - - contrib/kserve/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_knative.sh - - common/knative/** - - tests/gh-actions/install_kserve.sh + - .github/workflows/kserve_test.yaml + - contrib/kserve/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_knative.sh + - common/knative/** + - tests/gh-actions/install_kserve.sh jobs: build: @@ -17,10 +17,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/metacontroller_test.yaml b/.github/workflows/metacontroller_test.yaml index 0d1153636..595304ade 100644 --- a/.github/workflows/metacontroller_test.yaml +++ b/.github/workflows/metacontroller_test.yaml @@ -2,12 +2,12 @@ name: Build & Apply contrib/metacontroller in KinD on: pull_request: paths: - - .github/workflows/metacontroller_test.yaml - - contrib/metacontroller/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/metacontroller_test.yaml + - contrib/metacontroller/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: diff --git a/.github/workflows/model_registry_test.yaml b/.github/workflows/model_registry_test.yaml index b3e8f6eff..c0042aaa7 100644 --- a/.github/workflows/model_registry_test.yaml +++ b/.github/workflows/model_registry_test.yaml @@ -4,9 +4,9 @@ name: Deploy and test Kubeflow Model Registry on: pull_request: paths: - - apps/model-registry/upstream/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - apps/model-registry/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build-kfmr: diff --git a/.github/workflows/notebook_controller_m2m_test.yaml b/.github/workflows/notebook_controller_m2m_test.yaml index dd66bb76d..41ac66270 100644 --- a/.github/workflows/notebook_controller_m2m_test.yaml +++ b/.github/workflows/notebook_controller_m2m_test.yaml @@ -2,12 +2,12 @@ name: Test Notebook Controller with m2m auth manifests in KinD on: pull_request: paths: - - .github/workflows/notebook_controller_m2m_test.yaml - - apps/jupyter/** - - common/oidc-client/oauth2-proxy/** - - common/istio*/** - - tests/gh-actions/install_istio_with_ext_auth.sh* - - tests/gh-actions/install_multi_tenancy.sh + - .github/workflows/notebook_controller_m2m_test.yaml + - apps/jupyter/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - tests/gh-actions/install_istio_with_ext_auth.sh* + - tests/gh-actions/install_multi_tenancy.sh jobs: build: diff --git a/.github/workflows/notebook_controller_test.yaml b/.github/workflows/notebook_controller_test.yaml index 6573f8f79..1807538a3 100644 --- a/.github/workflows/notebook_controller_test.yaml +++ b/.github/workflows/notebook_controller_test.yaml @@ -2,10 +2,10 @@ name: Build & Apply Notebook Controller manifests in KinD on: pull_request: paths: - - .github/workflows/notebook_controller_test.yaml - - apps/jupyter/notebook-controller/upstream/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/notebook_controller_test.yaml + - apps/jupyter/notebook-controller/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 98e6e08d2..732a21b37 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -2,16 +2,16 @@ name: Create Pipeline Run from Kubeflow Notebook on: pull_request: paths: - - .github/workflows/pipeline_run_from_notebook.yaml - - apps/jupyter/notebook-controller/upstream/** - - apps/pipeline/upstream/** - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - common/oidc-client/oauth2-proxy/** - - common/istio*/** - - common/oidc-client/** - - apps/jupyter/** + - .github/workflows/pipeline_run_from_notebook.yaml + - apps/jupyter/notebook-controller/upstream/** + - apps/pipeline/upstream/** + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - common/oidc-client/** + - apps/jupyter/** jobs: build: diff --git a/.github/workflows/pipeline_test.yaml b/.github/workflows/pipeline_test.yaml index f1c44dac6..84eb74323 100644 --- a/.github/workflows/pipeline_test.yaml +++ b/.github/workflows/pipeline_test.yaml @@ -2,14 +2,14 @@ name: Deploy and test Kubeflow Pipelines manifests with m2m auth in KinD on: pull_request: paths: - - .github/workflows/pipeline_test.yaml - - apps/pipeline/upstream/** - - tests/gh-actions/install_istio.sh - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** - - common/oidc-client/oauth2-proxy/** - - common/istio*/** - - tests/gh-actions/install_istio_with_ext_auth.sh + - .github/workflows/pipeline_test.yaml + - apps/pipeline/upstream/** + - tests/gh-actions/install_istio.sh + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - tests/gh-actions/install_istio_with_ext_auth.sh jobs: build: diff --git a/.github/workflows/profiles_test.yaml b/.github/workflows/profiles_test.yaml index caaedac95..d5f292f3e 100644 --- a/.github/workflows/profiles_test.yaml +++ b/.github/workflows/profiles_test.yaml @@ -2,10 +2,10 @@ name: Build & Apply Profiles manifests in KinD on: pull_request: paths: - - .github/workflows/profiles_test.yaml - - apps/profiles/upstream/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/profiles_test.yaml + - apps/profiles/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: diff --git a/.github/workflows/ray_test.yaml b/.github/workflows/ray_test.yaml index 20fb858d5..855a75770 100644 --- a/.github/workflows/ray_test.yaml +++ b/.github/workflows/ray_test.yaml @@ -2,8 +2,8 @@ name: Build & Apply Ray manifest in KinD on: pull_request: paths: - - .github/workflows/ray_test.yaml - - contrib/ray/** + - .github/workflows/ray_test.yaml + - contrib/ray/** jobs: build: @@ -11,7 +11,7 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - + - name: Install KinD, Create KinD cluster and Install kustomize run: | chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh diff --git a/.github/workflows/seldon_test.yaml b/.github/workflows/seldon_test.yaml index 4688256e8..89245cbed 100644 --- a/.github/workflows/seldon_test.yaml +++ b/.github/workflows/seldon_test.yaml @@ -2,12 +2,12 @@ name: Build & Apply Seldon manifests in KinD on: pull_request: paths: - - .github/workflows/seldon_test.yaml - - contrib/seldon/** - - tests/gh-actions/install_istio.sh - - common/istio*/** - - tests/gh-actions/install_cert_manager.sh - - common/cert-manager/** + - .github/workflows/seldon_test.yaml + - contrib/seldon/** + - tests/gh-actions/install_istio.sh + - common/istio*/** + - tests/gh-actions/install_cert_manager.sh + - common/cert-manager/** jobs: build: diff --git a/.github/workflows/tensorboard_controller_test.yaml b/.github/workflows/tensorboard_controller_test.yaml index 94e5e0a53..835ab5900 100644 --- a/.github/workflows/tensorboard_controller_test.yaml +++ b/.github/workflows/tensorboard_controller_test.yaml @@ -2,10 +2,10 @@ name: Build & Apply Tensorboard Controller manifests in KinD on: pull_request: paths: - - .github/workflows/tensorboard_controller_test.yaml - - apps/tensorboard/tensorboard-controller/upstream/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/tensorboard_controller_test.yaml + - apps/tensorboard/tensorboard-controller/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: diff --git a/.github/workflows/tensorboards_web_application_test.yaml b/.github/workflows/tensorboards_web_application_test.yaml index 5c24d8129..e3eccd7b1 100644 --- a/.github/workflows/tensorboards_web_application_test.yaml +++ b/.github/workflows/tensorboards_web_application_test.yaml @@ -2,10 +2,10 @@ name: Build & Apply TWA manifests in KinD on: pull_request: paths: - - .github/workflows/tensorboards_web_application_test.yaml - - apps/tensorboard/tensorboards-web-app/upstream/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/tensorboards_web_application_test.yaml + - apps/tensorboard/tensorboards-web-app/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: diff --git a/.github/workflows/training_operator_test.yaml b/.github/workflows/training_operator_test.yaml index d386e124e..e47779a48 100644 --- a/.github/workflows/training_operator_test.yaml +++ b/.github/workflows/training_operator_test.yaml @@ -2,11 +2,11 @@ name: Build & Apply Training Operator manifests in KinD on: pull_request: paths: - - .github/workflows/training_operator_test.yaml - - apps/training-operator/upstream/** - - tests/gh-actions/install_istio.sh - - common/istio*/** - - tests/gh-actions/kf-objects/tfjob.yaml + - .github/workflows/training_operator_test.yaml + - apps/training-operator/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** + - tests/gh-actions/kf-objects/tfjob.yaml jobs: build: diff --git a/.github/workflows/volumes_web_application_test.yaml b/.github/workflows/volumes_web_application_test.yaml index c2a8d0f4f..b05254beb 100644 --- a/.github/workflows/volumes_web_application_test.yaml +++ b/.github/workflows/volumes_web_application_test.yaml @@ -2,10 +2,10 @@ name: Build & Apply VWA manifests in KinD on: pull_request: paths: - - .github/workflows/volumes_web_application_test.yaml - - apps/volumes-web-app/upstream/** - - tests/gh-actions/install_istio.sh - - common/istio*/** + - .github/workflows/volumes_web_application_test.yaml + - apps/volumes-web-app/upstream/** + - tests/gh-actions/install_istio.sh + - common/istio*/** jobs: build: From ba534bc37c938d6892952e15840603289737734c Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 21:41:04 +0530 Subject: [PATCH 09/28] fix trailing issues in workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/bentoml_test.yaml | 2 +- .github/workflows/pipeline_test.yaml | 8 ++++---- .github/workflows/ray_test.yaml | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index ab29d4689..fa5cf06c8 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -18,7 +18,7 @@ jobs: run: | chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - + - name: Install cert-manager run: ./tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/pipeline_test.yaml b/.github/workflows/pipeline_test.yaml index 84eb74323..7aaf38aab 100644 --- a/.github/workflows/pipeline_test.yaml +++ b/.github/workflows/pipeline_test.yaml @@ -18,10 +18,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: | + chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/ray_test.yaml b/.github/workflows/ray_test.yaml index 855a75770..4c30af543 100644 --- a/.github/workflows/ray_test.yaml +++ b/.github/workflows/ray_test.yaml @@ -11,7 +11,7 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - + - name: Install KinD, Create KinD cluster and Install kustomize run: | chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh From 4d2a032a8203b18075a4648d9e2b1eb6179ccb3a Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Tue, 30 Jul 2024 21:43:11 +0530 Subject: [PATCH 10/28] fix trailing issues in workflow file bentoml Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/bentoml_test.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index fa5cf06c8..bb2d127f0 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -18,7 +18,7 @@ jobs: run: | chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - + - name: Install cert-manager run: ./tests/gh-actions/install_cert_manager.sh From 0266c13b7b9fe7a8df151dc2bcb7ad4b3024137c Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Fri, 2 Aug 2024 14:41:03 +0530 Subject: [PATCH 11/28] made tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh executable and removed chmod command from the workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/admission_webhook_test.yaml | 4 +--- .github/workflows/bentoml_test.yaml | 4 +--- .github/workflows/centraldashboard_test.yaml | 4 +--- .github/workflows/dex_test.yaml | 4 +--- .github/workflows/jupyter_web_application_test.yaml | 4 +--- .github/workflows/katib_test.yaml | 4 +--- .github/workflows/kserve_cni_test.yaml | 4 +--- .github/workflows/kserve_m2m_test.yaml | 4 +--- .github/workflows/kserve_test.yaml | 4 +--- .github/workflows/metacontroller_test.yaml | 4 +--- .github/workflows/model_registry_test.yaml | 4 +--- .github/workflows/notebook_controller_m2m_test.yaml | 4 +--- .github/workflows/notebook_controller_test.yaml | 4 +--- .github/workflows/pipeline_run_from_notebook.yaml | 4 +--- .github/workflows/pipeline_test.yaml | 4 +--- .github/workflows/profiles_test.yaml | 4 +--- .github/workflows/ray_test.yaml | 4 +--- .github/workflows/seldon_test.yaml | 4 +--- .github/workflows/tensorboard_controller_test.yaml | 4 +--- .github/workflows/tensorboards_web_application_test.yaml | 4 +--- .github/workflows/training_operator_test.yaml | 4 +--- .github/workflows/volumes_web_application_test.yaml | 4 +--- .../install_KinD_create_KinD_cluster_install_kustomize.sh | 0 23 files changed, 22 insertions(+), 66 deletions(-) mode change 100644 => 100755 tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml index 723abbcb8..f865445dd 100644 --- a/.github/workflows/admission_webhook_test.yaml +++ b/.github/workflows/admission_webhook_test.yaml @@ -17,9 +17,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index bb2d127f0..327f2e818 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -15,9 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install cert-manager run: ./tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml index 244c54619..5690947af 100644 --- a/.github/workflows/centraldashboard_test.yaml +++ b/.github/workflows/centraldashboard_test.yaml @@ -14,9 +14,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml index c9276b5f9..3cb32aa8f 100644 --- a/.github/workflows/dex_test.yaml +++ b/.github/workflows/dex_test.yaml @@ -14,9 +14,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml index 19723ed4d..7aa592428 100644 --- a/.github/workflows/jupyter_web_application_test.yaml +++ b/.github/workflows/jupyter_web_application_test.yaml @@ -14,9 +14,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index 0d354601f..be5d7dabd 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -16,9 +16,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/kserve_cni_test.yaml b/.github/workflows/kserve_cni_test.yaml index d0fe52d29..3a0458ae7 100644 --- a/.github/workflows/kserve_cni_test.yaml +++ b/.github/workflows/kserve_cni_test.yaml @@ -18,9 +18,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/kserve_m2m_test.yaml b/.github/workflows/kserve_m2m_test.yaml index 1bd46c9ae..e9ed511a6 100644 --- a/.github/workflows/kserve_m2m_test.yaml +++ b/.github/workflows/kserve_m2m_test.yaml @@ -21,9 +21,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/kserve_test.yaml b/.github/workflows/kserve_test.yaml index a214a5b7e..9a5929f96 100644 --- a/.github/workflows/kserve_test.yaml +++ b/.github/workflows/kserve_test.yaml @@ -18,9 +18,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Create kubeflow namespace run: kustomize build common/kubeflow-namespace/base | kubectl apply -f - diff --git a/.github/workflows/metacontroller_test.yaml b/.github/workflows/metacontroller_test.yaml index 595304ade..be53cad00 100644 --- a/.github/workflows/metacontroller_test.yaml +++ b/.github/workflows/metacontroller_test.yaml @@ -17,9 +17,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/model_registry_test.yaml b/.github/workflows/model_registry_test.yaml index c0042aaa7..a041cd566 100644 --- a/.github/workflows/model_registry_test.yaml +++ b/.github/workflows/model_registry_test.yaml @@ -16,9 +16,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/notebook_controller_m2m_test.yaml b/.github/workflows/notebook_controller_m2m_test.yaml index 41ac66270..2f74f77c1 100644 --- a/.github/workflows/notebook_controller_m2m_test.yaml +++ b/.github/workflows/notebook_controller_m2m_test.yaml @@ -17,9 +17,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/notebook_controller_test.yaml b/.github/workflows/notebook_controller_test.yaml index 1807538a3..d5d2c4725 100644 --- a/.github/workflows/notebook_controller_test.yaml +++ b/.github/workflows/notebook_controller_test.yaml @@ -15,9 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 732a21b37..1415b929f 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -21,9 +21,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio with external authentication run: ./tests/gh-actions/install_istio_with_ext_auth.sh diff --git a/.github/workflows/pipeline_test.yaml b/.github/workflows/pipeline_test.yaml index 7aaf38aab..efa577983 100644 --- a/.github/workflows/pipeline_test.yaml +++ b/.github/workflows/pipeline_test.yaml @@ -19,9 +19,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/profiles_test.yaml b/.github/workflows/profiles_test.yaml index d5f292f3e..0cd776a07 100644 --- a/.github/workflows/profiles_test.yaml +++ b/.github/workflows/profiles_test.yaml @@ -15,9 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/ray_test.yaml b/.github/workflows/ray_test.yaml index 4c30af543..ee4ec5280 100644 --- a/.github/workflows/ray_test.yaml +++ b/.github/workflows/ray_test.yaml @@ -13,9 +13,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Build & Apply manifests run: | diff --git a/.github/workflows/seldon_test.yaml b/.github/workflows/seldon_test.yaml index 89245cbed..a58d3a5b6 100644 --- a/.github/workflows/seldon_test.yaml +++ b/.github/workflows/seldon_test.yaml @@ -17,9 +17,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboard_controller_test.yaml b/.github/workflows/tensorboard_controller_test.yaml index 835ab5900..c3426ea4b 100644 --- a/.github/workflows/tensorboard_controller_test.yaml +++ b/.github/workflows/tensorboard_controller_test.yaml @@ -15,9 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboards_web_application_test.yaml b/.github/workflows/tensorboards_web_application_test.yaml index e3eccd7b1..e28e63bde 100644 --- a/.github/workflows/tensorboards_web_application_test.yaml +++ b/.github/workflows/tensorboards_web_application_test.yaml @@ -15,9 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/.github/workflows/training_operator_test.yaml b/.github/workflows/training_operator_test.yaml index e47779a48..373d025af 100644 --- a/.github/workflows/training_operator_test.yaml +++ b/.github/workflows/training_operator_test.yaml @@ -16,9 +16,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh diff --git a/.github/workflows/volumes_web_application_test.yaml b/.github/workflows/volumes_web_application_test.yaml index b05254beb..cdf529635 100644 --- a/.github/workflows/volumes_web_application_test.yaml +++ b/.github/workflows/volumes_web_application_test.yaml @@ -15,9 +15,7 @@ jobs: uses: actions/checkout@v4 - name: Install KinD, Create KinD cluster and Install kustomize - run: | - chmod +x tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install Istio run: ./tests/gh-actions/install_istio.sh diff --git a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh old mode 100644 new mode 100755 From ef7080a0b75432f3404b8664294577b16755de89 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Fri, 2 Aug 2024 14:55:28 +0530 Subject: [PATCH 12/28] made modifications in workflow files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/admission_webhook_test.yaml | 2 +- .github/workflows/bentoml_test.yaml | 1 + .github/workflows/centraldashboard_test.yaml | 1 + .github/workflows/dex_test.yaml | 1 + .github/workflows/jupyter_web_application_test.yaml | 1 + .github/workflows/katib_test.yaml | 1 + .github/workflows/kserve_cni_test.yaml | 1 + .github/workflows/kserve_m2m_test.yaml | 1 + .github/workflows/kserve_test.yaml | 1 + .github/workflows/metacontroller_test.yaml | 1 + .github/workflows/model_registry_test.yaml | 1 + .github/workflows/notebook_controller_m2m_test.yaml | 1 + .github/workflows/notebook_controller_test.yaml | 1 + .github/workflows/pipeline_run_from_notebook.yaml | 1 + .github/workflows/pipeline_test.yaml | 1 + .github/workflows/profiles_test.yaml | 1 + .github/workflows/ray_test.yaml | 1 + .github/workflows/seldon_test.yaml | 1 + .github/workflows/tensorboard_controller_test.yaml | 1 + .github/workflows/tensorboards_web_application_test.yaml | 1 + .github/workflows/training_operator_test.yaml | 1 + .github/workflows/volumes_web_application_test.yaml | 1 + 22 files changed, 22 insertions(+), 1 deletion(-) diff --git a/.github/workflows/admission_webhook_test.yaml b/.github/workflows/admission_webhook_test.yaml index f865445dd..fecfb8b5e 100644 --- a/.github/workflows/admission_webhook_test.yaml +++ b/.github/workflows/admission_webhook_test.yaml @@ -2,9 +2,9 @@ name: Build & Apply PodDefaults manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/admission_webhook_test.yaml - apps/admission-webhook/upstream/** - - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - tests/gh-actions/install_istio.sh - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/bentoml_test.yaml b/.github/workflows/bentoml_test.yaml index 327f2e818..ad234ba55 100644 --- a/.github/workflows/bentoml_test.yaml +++ b/.github/workflows/bentoml_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply BentoML Yatai Stack manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/bentoml_test.yaml - tests/gh-actions/install_cert_manager.sh - common/cert-manager/** diff --git a/.github/workflows/centraldashboard_test.yaml b/.github/workflows/centraldashboard_test.yaml index 5690947af..4ec4c0baf 100644 --- a/.github/workflows/centraldashboard_test.yaml +++ b/.github/workflows/centraldashboard_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply CentralDashboard manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/centraldashboard_test.yaml - apps/centraldashboard/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/dex_test.yaml b/.github/workflows/dex_test.yaml index 3cb32aa8f..a2f51aced 100644 --- a/.github/workflows/dex_test.yaml +++ b/.github/workflows/dex_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Dex manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/dex_test.yaml - common/dex/base/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/jupyter_web_application_test.yaml b/.github/workflows/jupyter_web_application_test.yaml index 7aa592428..f1054d15b 100644 --- a/.github/workflows/jupyter_web_application_test.yaml +++ b/.github/workflows/jupyter_web_application_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply JWA manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/jupyter_web_application_test.yaml - apps/jupyter/jupyter-web-app/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index be5d7dabd..07d0907d6 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Katib manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/katib_test.yaml - apps/katib/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/kserve_cni_test.yaml b/.github/workflows/kserve_cni_test.yaml index 3a0458ae7..f8c8c5cd5 100644 --- a/.github/workflows/kserve_cni_test.yaml +++ b/.github/workflows/kserve_cni_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply KServe manifests in KinD, using istio CNI on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/kserve_cni_test.yaml - common/istio-cni-1-22/** - tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/kserve_m2m_test.yaml b/.github/workflows/kserve_m2m_test.yaml index e9ed511a6..8a057accc 100644 --- a/.github/workflows/kserve_m2m_test.yaml +++ b/.github/workflows/kserve_m2m_test.yaml @@ -2,6 +2,7 @@ name: Deploy and test KServe with m2m auth in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/kserve_m2m_test.yaml - contrib/kserve/** - common/oidc-client/oauth2-proxy/** diff --git a/.github/workflows/kserve_test.yaml b/.github/workflows/kserve_test.yaml index 9a5929f96..0a01979c7 100644 --- a/.github/workflows/kserve_test.yaml +++ b/.github/workflows/kserve_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply KServe manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/kserve_test.yaml - contrib/kserve/** - tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/metacontroller_test.yaml b/.github/workflows/metacontroller_test.yaml index be53cad00..3774304fa 100644 --- a/.github/workflows/metacontroller_test.yaml +++ b/.github/workflows/metacontroller_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply contrib/metacontroller in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/metacontroller_test.yaml - contrib/metacontroller/** - tests/gh-actions/install_cert_manager.sh diff --git a/.github/workflows/model_registry_test.yaml b/.github/workflows/model_registry_test.yaml index a041cd566..2b18e27bf 100644 --- a/.github/workflows/model_registry_test.yaml +++ b/.github/workflows/model_registry_test.yaml @@ -4,6 +4,7 @@ name: Deploy and test Kubeflow Model Registry on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - apps/model-registry/upstream/** - tests/gh-actions/install_istio.sh - common/istio*/** diff --git a/.github/workflows/notebook_controller_m2m_test.yaml b/.github/workflows/notebook_controller_m2m_test.yaml index 2f74f77c1..54a53e5f1 100644 --- a/.github/workflows/notebook_controller_m2m_test.yaml +++ b/.github/workflows/notebook_controller_m2m_test.yaml @@ -2,6 +2,7 @@ name: Test Notebook Controller with m2m auth manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/notebook_controller_m2m_test.yaml - apps/jupyter/** - common/oidc-client/oauth2-proxy/** diff --git a/.github/workflows/notebook_controller_test.yaml b/.github/workflows/notebook_controller_test.yaml index d5d2c4725..31bba9579 100644 --- a/.github/workflows/notebook_controller_test.yaml +++ b/.github/workflows/notebook_controller_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Notebook Controller manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/notebook_controller_test.yaml - apps/jupyter/notebook-controller/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 1415b929f..d035a30ad 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -2,6 +2,7 @@ name: Create Pipeline Run from Kubeflow Notebook on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/pipeline_run_from_notebook.yaml - apps/jupyter/notebook-controller/upstream/** - apps/pipeline/upstream/** diff --git a/.github/workflows/pipeline_test.yaml b/.github/workflows/pipeline_test.yaml index efa577983..61b05258c 100644 --- a/.github/workflows/pipeline_test.yaml +++ b/.github/workflows/pipeline_test.yaml @@ -2,6 +2,7 @@ name: Deploy and test Kubeflow Pipelines manifests with m2m auth in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/pipeline_test.yaml - apps/pipeline/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/profiles_test.yaml b/.github/workflows/profiles_test.yaml index 0cd776a07..c1ad802a8 100644 --- a/.github/workflows/profiles_test.yaml +++ b/.github/workflows/profiles_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Profiles manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/profiles_test.yaml - apps/profiles/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/ray_test.yaml b/.github/workflows/ray_test.yaml index ee4ec5280..20e387015 100644 --- a/.github/workflows/ray_test.yaml +++ b/.github/workflows/ray_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Ray manifest in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/ray_test.yaml - contrib/ray/** diff --git a/.github/workflows/seldon_test.yaml b/.github/workflows/seldon_test.yaml index a58d3a5b6..5653358bc 100644 --- a/.github/workflows/seldon_test.yaml +++ b/.github/workflows/seldon_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Seldon manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/seldon_test.yaml - contrib/seldon/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboard_controller_test.yaml b/.github/workflows/tensorboard_controller_test.yaml index c3426ea4b..f6b248fde 100644 --- a/.github/workflows/tensorboard_controller_test.yaml +++ b/.github/workflows/tensorboard_controller_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Tensorboard Controller manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/tensorboard_controller_test.yaml - apps/tensorboard/tensorboard-controller/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/tensorboards_web_application_test.yaml b/.github/workflows/tensorboards_web_application_test.yaml index e28e63bde..377f83c47 100644 --- a/.github/workflows/tensorboards_web_application_test.yaml +++ b/.github/workflows/tensorboards_web_application_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply TWA manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/tensorboards_web_application_test.yaml - apps/tensorboard/tensorboards-web-app/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/training_operator_test.yaml b/.github/workflows/training_operator_test.yaml index 373d025af..8d469e6c7 100644 --- a/.github/workflows/training_operator_test.yaml +++ b/.github/workflows/training_operator_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply Training Operator manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/training_operator_test.yaml - apps/training-operator/upstream/** - tests/gh-actions/install_istio.sh diff --git a/.github/workflows/volumes_web_application_test.yaml b/.github/workflows/volumes_web_application_test.yaml index cdf529635..7305d3bde 100644 --- a/.github/workflows/volumes_web_application_test.yaml +++ b/.github/workflows/volumes_web_application_test.yaml @@ -2,6 +2,7 @@ name: Build & Apply VWA manifests in KinD on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/volumes_web_application_test.yaml - apps/volumes-web-app/upstream/** - tests/gh-actions/install_istio.sh From 8792230ff09fb6a9ebb26bc4933493d22cf1ecf8 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Fri, 2 Aug 2024 18:03:54 +0530 Subject: [PATCH 13/28] deleted redundant files from tests folder Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- tests/gh-actions/install_kind.sh | 15 --------------- tests/gh-actions/install_kustomize.sh | 6 ------ tests/gh-actions/kind-cluster.yaml | 26 -------------------------- 3 files changed, 47 deletions(-) delete mode 100755 tests/gh-actions/install_kind.sh delete mode 100755 tests/gh-actions/install_kustomize.sh delete mode 100644 tests/gh-actions/kind-cluster.yaml diff --git a/tests/gh-actions/install_kind.sh b/tests/gh-actions/install_kind.sh deleted file mode 100755 index 37f89ad92..000000000 --- a/tests/gh-actions/install_kind.sh +++ /dev/null @@ -1,15 +0,0 @@ -#!/bin/bash -set -e -echo "Fetching KinD executable ..." -sudo swapoff -a - -# This conditional helps running GH Workflows through -# [act](https://github.com/nektos/act) -if [ -e /swapfile ]; then - sudo rm -f /swapfile - sudo mkdir -p /tmp/etcd - sudo mount -t tmpfs tmpfs /tmp/etcd -fi -curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.20.0/kind-linux-amd64 -chmod +x ./kind -sudo mv kind /usr/local/bin \ No newline at end of file diff --git a/tests/gh-actions/install_kustomize.sh b/tests/gh-actions/install_kustomize.sh deleted file mode 100755 index 025f81a68..000000000 --- a/tests/gh-actions/install_kustomize.sh +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/bash -set -e -curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_amd64.tar.gz" -tar -xzvf kustomize_v5.2.1_linux_amd64.tar.gz -chmod a+x kustomize -sudo mv kustomize /usr/local/bin/kustomize diff --git a/tests/gh-actions/kind-cluster.yaml b/tests/gh-actions/kind-cluster.yaml deleted file mode 100644 index 83dd8b332..000000000 --- a/tests/gh-actions/kind-cluster.yaml +++ /dev/null @@ -1,26 +0,0 @@ -apiVersion: kind.x-k8s.io/v1alpha4 -kind: Cluster -# Configure registry for KinD. -containerdConfigPatches: -- |- - [plugins."io.containerd.grpc.v1.cri".registry.mirrors."$REGISTRY_NAME:$REGISTRY_PORT"] - endpoint = ["http://$REGISTRY_NAME:$REGISTRY_PORT"] -# This is needed in order to support projected volumes with service account tokens. -# See: https://kubernetes.slack.com/archives/CEKK1KTN2/p1600268272383600 -kubeadmConfigPatches: - - | - apiVersion: kubeadm.k8s.io/v1beta2 - kind: ClusterConfiguration - metadata: - name: config - apiServer: - extraArgs: - "service-account-issuer": "kubernetes.default.svc" - "service-account-signing-key-file": "/etc/kubernetes/pki/sa.key" -nodes: -- role: control-plane - image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 -- role: worker - image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 -- role: worker - image: kindest/node:v1.29.4@sha256:3abb816a5b1061fb15c6e9e60856ec40d56b7b52bcea5f5f1350bc6e2320b6f8 \ No newline at end of file From 7aca48c3500e588d3ff48a88939a6f6642bda614 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Fri, 2 Aug 2024 18:56:52 +0530 Subject: [PATCH 14/28] Add kustomize installation file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- tests/gh-actions/install_kustomize.sh | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 tests/gh-actions/install_kustomize.sh diff --git a/tests/gh-actions/install_kustomize.sh b/tests/gh-actions/install_kustomize.sh new file mode 100644 index 000000000..025f81a68 --- /dev/null +++ b/tests/gh-actions/install_kustomize.sh @@ -0,0 +1,6 @@ +#!/bin/bash +set -e +curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_amd64.tar.gz" +tar -xzvf kustomize_v5.2.1_linux_amd64.tar.gz +chmod a+x kustomize +sudo mv kustomize /usr/local/bin/kustomize From c1559f93f7198753221b613fadc327561e064c2a Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Fri, 2 Aug 2024 18:59:29 +0530 Subject: [PATCH 15/28] made install_kustomize.sh file executable Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- tests/gh-actions/install_kustomize.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tests/gh-actions/install_kustomize.sh diff --git a/tests/gh-actions/install_kustomize.sh b/tests/gh-actions/install_kustomize.sh old mode 100644 new mode 100755 From e2a6ec70fcd15c30d54d447fc79a12e8ffb23823 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Fri, 2 Aug 2024 19:36:17 +0530 Subject: [PATCH 16/28] made a fix Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- tests/gh-actions/install_istio_with_ext_auth.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/gh-actions/install_istio_with_ext_auth.sh b/tests/gh-actions/install_istio_with_ext_auth.sh index 871fec394..6b56131ea 100755 --- a/tests/gh-actions/install_istio_with_ext_auth.sh +++ b/tests/gh-actions/install_istio_with_ext_auth.sh @@ -14,4 +14,4 @@ kubectl wait --for=condition=Ready pods --all -n istio-system --timeout=300s \ echo "Installing oauth2-proxy..." cd common/ kustomize build oauth2-proxy/overlays/m2m-self-signed/ | kubectl apply -f - -kubectl wait --for=condition=ready pod -l 'app.kubernetes.io/name=oauth2-proxy' --timeout=180s -n oauth2-proxy +kubectl wait --for=condition=ready pod -l 'app.kubernetes.io/name=oauth2-proxy' --timeout=180s -n oauth2-proxy \ No newline at end of file From a57a95ffb620971a15afcfb5be9b80170b8f9d4a Mon Sep 17 00:00:00 2001 From: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Mon, 5 Aug 2024 18:47:39 +0530 Subject: [PATCH 17/28] fix issue with linting of YAML files (#2825) * fix issue with linting of YAML files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * delete a file to check the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add the after checking the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add folders to yaml linting Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting issues Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting issues Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting changes Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * check linting functionality by chnaging different files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * made some fixes in linting YAML file and check the functionality Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add github, hack and tests folders also for linting Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Check functionality by deleting sh from hack and yaml file common Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Added deleted files Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --------- Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- .github/workflows/linting_bash_python_yaml_files.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linting_bash_python_yaml_files.yaml b/.github/workflows/linting_bash_python_yaml_files.yaml index bd38c1eea..90556097d 100644 --- a/.github/workflows/linting_bash_python_yaml_files.yaml +++ b/.github/workflows/linting_bash_python_yaml_files.yaml @@ -71,7 +71,7 @@ jobs: - name: Set up changed files id: changed_files run: | - git diff --name-status origin/master...HEAD | grep -E '^[AM].*\.(yaml|yml)$' | awk '{print $2}' > changed_files_in_PR.txt || true + git diff --name-only --diff-filter=AM origin/master...HEAD | grep -E '^common/.*\.ya?ml$|^example/.*\.ya?ml$|^hack/.*\.ya?ml$|^tests/.*\.ya?ml$|^.github/.*\.ya?ml$' > changed_files_in_PR.txt || true if [ ! -s changed_files_in_PR.txt ]; then echo "No YAML files have changed in this PR." > changed_files_in_PR.txt fi From 1cfd844f37c784d5f993e40d8b9fdbfdd73d518c Mon Sep 17 00:00:00 2001 From: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Mon, 5 Aug 2024 18:57:38 +0530 Subject: [PATCH 18/28] Expose Ray and Seldon to example kustomization.yaml file (#2834) * Expose Ray and Seldon to example kustomization.yaml file Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> * Add internal documentations for ray and seldon Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> --------- Signed-off-by: hansinikarunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Signed-off-by: hansinikarunarathne --- example/kustomization.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/example/kustomization.yaml b/example/kustomization.yaml index 0308d5e60..88c84cb32 100644 --- a/example/kustomization.yaml +++ b/example/kustomization.yaml @@ -90,6 +90,17 @@ resources: - ../contrib/kserve/kserve - ../contrib/kserve/models-web-app/overlays/kubeflow +# Ray and Seldon resources (commented out by default) +# Ray does not support Istio yet and integration is in alpha state. +# Here is the documentation for Ray: https://docs.ray.io/en/latest/ +# Here is the internal documentation for Ray: - ../contrib/ray/README.md +# - ../contrib/ray/kuberay-operator/overlays/kubeflow +# +# Seldon integration notes: Seldon may have specific requirements and limitations. +# Documentation for Seldon: https://docs.seldon.io/projects/seldon-core/en/latest/ +# Here is the internal documentation for Seldon: - ../contrib/seldon/README.md +# - ../contrib/seldon/seldon-core-operator/overlays/application + components: # Pod Security Standards # https://kubernetes.io/docs/concepts/security/pod-security-standards/ From 159abc991050c43b99f0b05f937d71ec72dbfe04 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Thu, 8 Aug 2024 14:02:59 +0530 Subject: [PATCH 19/28] Increase the time out of notebook and katib test Signed-off-by: hansinikarunarathne --- .github/workflows/katib_test.yaml | 2 +- .github/workflows/pipeline_run_from_notebook.yaml | 2 +- .../install_KinD_create_KinD_cluster_install_kustomize.sh | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index 07d0907d6..973fa1558 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -49,7 +49,7 @@ jobs: kubectl wait --for=condition=Running experiments.kubeflow.org -n kubeflow-user --all --timeout 300s echo "Waiting for all Trials to become Succeeded..." - kubectl wait --for=condition=Succeeded trials.kubeflow.org -n kubeflow-user --all --timeout 300s + kubectl wait --for=condition=Succeeded trials.kubeflow.org -n kubeflow-user --all --timeout 600s echo "Waiting for the Experiment to become Succeeded..." kubectl wait --for=condition=Succeeded experiments.kubeflow.org -n kubeflow-user --all --timeout 300s diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index d035a30ad..918f5a798 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -61,7 +61,7 @@ jobs: kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml kubectl wait --for=jsonpath='{.status.readyReplicas}'=1 \ -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml \ - --timeout 300s + --timeout 600s - name: Wait for the kubeflow-m2m-oidc-configurator Job run: | diff --git a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh index 37e80d0fd..59e01d244 100755 --- a/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh +++ b/tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh @@ -33,8 +33,8 @@ kind: Cluster # Configure registry for KinD. containerdConfigPatches: - |- - [plugins.\"io.containerd.grpc.v1.cri\".registry.mirrors.\"$REGISTRY_NAME:$REGISTRY_PORT\"] - endpoint = [\"http://$REGISTRY_NAME:$REGISTRY_PORT\"] + [plugins.\"io.containerd.grpc.v1.cri\".registry.mirrors.\"REGISTRY_NAME:REGISTRY_PORT\"] + endpoint = [\"http://REGISTRY_NAME:REGISTRY_PORT\"] # This is needed in order to support projected volumes with service account tokens. # See: https://kubernetes.slack.com/archives/CEKK1KTN2/p1600268272383600 kubeadmConfigPatches: From 08e8f579b46e77521d2b872c11e99345d3f3c21c Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Fri, 9 Aug 2024 20:59:20 +0530 Subject: [PATCH 20/28] increase the timout time Signed-off-by: hansinikarunarathne --- .github/workflows/katib_test.yaml | 2 +- .github/workflows/pipeline_run_from_notebook.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/katib_test.yaml b/.github/workflows/katib_test.yaml index 973fa1558..841da24e6 100644 --- a/.github/workflows/katib_test.yaml +++ b/.github/workflows/katib_test.yaml @@ -49,7 +49,7 @@ jobs: kubectl wait --for=condition=Running experiments.kubeflow.org -n kubeflow-user --all --timeout 300s echo "Waiting for all Trials to become Succeeded..." - kubectl wait --for=condition=Succeeded trials.kubeflow.org -n kubeflow-user --all --timeout 600s + kubectl wait --for=condition=Succeeded trials.kubeflow.org -n kubeflow-user --all --timeout 1200s echo "Waiting for the Experiment to become Succeeded..." kubectl wait --for=condition=Succeeded experiments.kubeflow.org -n kubeflow-user --all --timeout 300s diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 918f5a798..e19913a99 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -61,7 +61,7 @@ jobs: kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml kubectl wait --for=jsonpath='{.status.readyReplicas}'=1 \ -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml \ - --timeout 600s + --timeout 1200s - name: Wait for the kubeflow-m2m-oidc-configurator Job run: | From e847d4f58c41727d04e80216d1e727f7f4b2eefb Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Fri, 9 Aug 2024 21:28:11 +0530 Subject: [PATCH 21/28] increase timeout of the create pipeline Run from Kubeflow Notebook to 2400s Signed-off-by: hansinikarunarathne --- .github/workflows/pipeline_run_from_notebook.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index e19913a99..d11c6879f 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -61,7 +61,7 @@ jobs: kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml kubectl wait --for=jsonpath='{.status.readyReplicas}'=1 \ -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml \ - --timeout 1200s + --timeout 2400s - name: Wait for the kubeflow-m2m-oidc-configurator Job run: | From 6de8ebcb2bc9412a934506936b6ed12733976d72 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Wed, 14 Aug 2024 19:39:14 +0530 Subject: [PATCH 22/28] Add code to calculate time taken to pull a docker image Signed-off-by: hansinikarunarathne --- .github/workflows/pipeline_run_from_notebook.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index d11c6879f..0b0fed63f 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -56,6 +56,15 @@ jobs: - name: Apply PodDefaults to access ml-pipeline with projected token run: kubectl apply -f tests/gh-actions/kf-objects/poddefaults.access-ml-pipeline.kubeflow-user-example-com.yaml + - name: Measure time to pull Docker image + run: | + start_time=$(date +%s) + kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml + end_time=$(date +%s) + image_pull_time=$((end_time - start_time)) + echo "Image pull and deployment took $image_pull_time seconds." + shell: bash + - name: Create Kubeflow Notebook with PodDefaults run: | kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml From 3227d170cdd778e80cfc387adb7e72f3a7da6ab3 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Wed, 14 Aug 2024 19:49:11 +0530 Subject: [PATCH 23/28] fix syntax error in yaml file Signed-off-by: hansinikarunarathne --- .github/workflows/pipeline_run_from_notebook.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 0b0fed63f..bec235e50 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -58,12 +58,12 @@ jobs: - name: Measure time to pull Docker image run: | - start_time=$(date +%s) - kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml - end_time=$(date +%s) - image_pull_time=$((end_time - start_time)) - echo "Image pull and deployment took $image_pull_time seconds." - shell: bash + start_time=$(date +%s) + kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml + end_time=$(date +%s) + image_pull_time=$((end_time - start_time)) + echo "Image pull and deployment took $image_pull_time seconds." + shell: bash - name: Create Kubeflow Notebook with PodDefaults run: | From 33c0419f6de2d505873ed51f8913f349fbd12d7f Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Wed, 14 Aug 2024 22:58:18 +0530 Subject: [PATCH 24/28] increase pipeline time Signed-off-by: hansinikarunarathne --- .github/workflows/pipeline_run_from_notebook.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index bec235e50..9d9ad241a 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -70,7 +70,7 @@ jobs: kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml kubectl wait --for=jsonpath='{.status.readyReplicas}'=1 \ -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml \ - --timeout 2400s + --timeout 3600s - name: Wait for the kubeflow-m2m-oidc-configurator Job run: | From 12b137574d77afd70ee3d32ac497dcd6c8809684 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Wed, 14 Aug 2024 23:21:37 +0530 Subject: [PATCH 25/28] remove one step in action Signed-off-by: hansinikarunarathne --- .github/workflows/pipeline_run_from_notebook.yaml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index 9d9ad241a..a73b19077 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -56,15 +56,6 @@ jobs: - name: Apply PodDefaults to access ml-pipeline with projected token run: kubectl apply -f tests/gh-actions/kf-objects/poddefaults.access-ml-pipeline.kubeflow-user-example-com.yaml - - name: Measure time to pull Docker image - run: | - start_time=$(date +%s) - kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml - end_time=$(date +%s) - image_pull_time=$((end_time - start_time)) - echo "Image pull and deployment took $image_pull_time seconds." - shell: bash - - name: Create Kubeflow Notebook with PodDefaults run: | kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml From d925710bad99d1d8a27f324a907ed7d273b8ceba Mon Sep 17 00:00:00 2001 From: biswajit-9776 <115724497+biswajit-9776@users.noreply.github.com> Date: Mon, 12 Aug 2024 16:01:41 +0530 Subject: [PATCH 26/28] Added tests to tests/gh-actions to enable baseline and restricted PSS (#2819) * Patched PSS labels to multi_tenancy Signed-off-by: biswajit-9776 * Added script in gh-actions to patch PSS/static/baseline/pacthes Signed-off-by: biswajit-9776 * Added PSS scripts for both baseline and restricted labels of static namespaces and renamed directories Signed-off-by: biswajit-9776 * Added tests to enable PSS in gh-actions Signed-off-by: biswajit-9776 * Added workflow test for PSS labels Signed-off-by: biswajit-9776 * Fixed indentation Signed-off-by: biswajit-9776 --------- Signed-off-by: biswajit-9776 Signed-off-by: hansinikarunarathne --- .github/workflows/pss_test.yaml | 35 +++++++++++++++++++ .../PSS/static/baseline/kustomization.yaml | 6 ++-- .../{dex-labels.yaml => auth-labels.yaml} | 0 ...o-labels.yaml => istio-system-labels.yaml} | 0 .../PSS/static/restricted/kustomization.yaml | 5 ++- .../{dex-labels.yaml => auth-labels.yaml} | 0 ...o-labels.yaml => istio-system-labels.yaml} | 0 tests/gh-actions/enable_baseline_PSS.sh | 10 ++++++ tests/gh-actions/enable_restricted_PSS.sh | 10 ++++++ 9 files changed, 60 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/pss_test.yaml rename contrib/security/PSS/static/baseline/patches/{dex-labels.yaml => auth-labels.yaml} (100%) rename contrib/security/PSS/static/baseline/patches/{istio-labels.yaml => istio-system-labels.yaml} (100%) rename contrib/security/PSS/static/restricted/patches/{dex-labels.yaml => auth-labels.yaml} (100%) rename contrib/security/PSS/static/restricted/patches/{istio-labels.yaml => istio-system-labels.yaml} (100%) create mode 100755 tests/gh-actions/enable_baseline_PSS.sh create mode 100755 tests/gh-actions/enable_restricted_PSS.sh diff --git a/.github/workflows/pss_test.yaml b/.github/workflows/pss_test.yaml new file mode 100644 index 000000000..9aded5a7f --- /dev/null +++ b/.github/workflows/pss_test.yaml @@ -0,0 +1,35 @@ +name: Appy PSS labels to namespaces +on: + pull_request: + paths: + - .github/workflows/* + - tests/gh-actions/kind-cluster.yaml + - apps/profiles/upstream/** + - common/dex/** + - common/cert-manager/** + - common/oidc-client/oauth2-proxy/** + - common/istio*/** + - tests/gh-actions/install_istio_with_ext_auth.sh + - tests/gh-actions/install_multitenancy.sh + +jobs: + build: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v4 + + - name: Install KinD + run: ./tests/gh-actions/install_kind.sh + + - name: Create KinD Cluster + run: kind create cluster --config tests/gh-actions/kind-cluster.yaml + + - name: Install kustomize + run: ./tests/gh-actions/install_kustomize.sh + + - name: Install kubectl + run: ./tests/gh-actions/install_kubectl.sh + + - name: Applying Pod Security Standards baseline levels for static namespaces + run: ./tests/gh-actions/enable_baseline_PSS.sh diff --git a/contrib/security/PSS/static/baseline/kustomization.yaml b/contrib/security/PSS/static/baseline/kustomization.yaml index ec133f809..4550b10fc 100644 --- a/contrib/security/PSS/static/baseline/kustomization.yaml +++ b/contrib/security/PSS/static/baseline/kustomization.yaml @@ -3,7 +3,7 @@ kind: Component patches: - path: patches/kubeflow-labels.yaml -- path: patches/istio-labels.yaml +- path: patches/istio-system-labels.yaml - path: patches/cert-manager-labels.yaml -- path: patches/dex-labels.yaml -- path: patches/oauth2-proxy-labels.yaml \ No newline at end of file +- path: patches/auth-labels.yaml +- path: patches/oauth2-proxy-labels.yaml diff --git a/contrib/security/PSS/static/baseline/patches/dex-labels.yaml b/contrib/security/PSS/static/baseline/patches/auth-labels.yaml similarity index 100% rename from contrib/security/PSS/static/baseline/patches/dex-labels.yaml rename to contrib/security/PSS/static/baseline/patches/auth-labels.yaml diff --git a/contrib/security/PSS/static/baseline/patches/istio-labels.yaml b/contrib/security/PSS/static/baseline/patches/istio-system-labels.yaml similarity index 100% rename from contrib/security/PSS/static/baseline/patches/istio-labels.yaml rename to contrib/security/PSS/static/baseline/patches/istio-system-labels.yaml diff --git a/contrib/security/PSS/static/restricted/kustomization.yaml b/contrib/security/PSS/static/restricted/kustomization.yaml index f42ff9746..4550b10fc 100644 --- a/contrib/security/PSS/static/restricted/kustomization.yaml +++ b/contrib/security/PSS/static/restricted/kustomization.yaml @@ -3,8 +3,7 @@ kind: Component patches: - path: patches/kubeflow-labels.yaml -- path: patches/istio-labels.yaml +- path: patches/istio-system-labels.yaml - path: patches/cert-manager-labels.yaml -- path: patches/dex-labels.yaml +- path: patches/auth-labels.yaml - path: patches/oauth2-proxy-labels.yaml -- path: patches/istio-labels.yaml diff --git a/contrib/security/PSS/static/restricted/patches/dex-labels.yaml b/contrib/security/PSS/static/restricted/patches/auth-labels.yaml similarity index 100% rename from contrib/security/PSS/static/restricted/patches/dex-labels.yaml rename to contrib/security/PSS/static/restricted/patches/auth-labels.yaml diff --git a/contrib/security/PSS/static/restricted/patches/istio-labels.yaml b/contrib/security/PSS/static/restricted/patches/istio-system-labels.yaml similarity index 100% rename from contrib/security/PSS/static/restricted/patches/istio-labels.yaml rename to contrib/security/PSS/static/restricted/patches/istio-system-labels.yaml diff --git a/tests/gh-actions/enable_baseline_PSS.sh b/tests/gh-actions/enable_baseline_PSS.sh new file mode 100755 index 000000000..94bbcbad1 --- /dev/null +++ b/tests/gh-actions/enable_baseline_PSS.sh @@ -0,0 +1,10 @@ +#!/bin/bash + +NAMESPACES=("istio-system" "auth" "cert-manager" "oauth2-proxy" "kubeflow") + +for NAMESPACE in "${NAMESPACES[@]}"; do + if kubectl get namespace "$NAMESPACE" >/dev/null 2>&1; then + echo "Patching the PSS-baseline labels for namespace $NAMESPACE..." + kubectl patch namespace $NAMESPACE --patch-file ./contrib/security/PSS/static/baseline/patches/${NAMESPACE}-labels.yaml + fi +done diff --git a/tests/gh-actions/enable_restricted_PSS.sh b/tests/gh-actions/enable_restricted_PSS.sh new file mode 100755 index 000000000..5c17ce2ea --- /dev/null +++ b/tests/gh-actions/enable_restricted_PSS.sh @@ -0,0 +1,10 @@ +#!/bin/bash + +NAMESPACES=("istio-system" "auth" "cert-manager" "oauth2-proxy" "kubeflow") + +for NAMESPACE in "${NAMESPACES[@]}"; do + if kubectl get namespace "$NAMESPACE" >/dev/null 2>&1; then + echo "Patching the PSS-restricted labels for namespace $NAMESPACE..." + kubectl patch namespace $NAMESPACE --patch-file ./contrib/security/PSS/static/restricted/patches/${NAMESPACE}-labels.yaml + fi +done From 370250098487144c0b005e69cf4ceb75e746e799 Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Thu, 15 Aug 2024 00:32:54 +0530 Subject: [PATCH 27/28] add kind cluster step into pss test yaml file Signed-off-by: hansinikarunarathne --- .github/workflows/pss_test.yaml | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/pss_test.yaml b/.github/workflows/pss_test.yaml index 9aded5a7f..6f67e8b53 100644 --- a/.github/workflows/pss_test.yaml +++ b/.github/workflows/pss_test.yaml @@ -2,6 +2,7 @@ name: Appy PSS labels to namespaces on: pull_request: paths: + - tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - .github/workflows/* - tests/gh-actions/kind-cluster.yaml - apps/profiles/upstream/** @@ -19,14 +20,8 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Install KinD - run: ./tests/gh-actions/install_kind.sh - - - name: Create KinD Cluster - run: kind create cluster --config tests/gh-actions/kind-cluster.yaml - - - name: Install kustomize - run: ./tests/gh-actions/install_kustomize.sh + - name: Install KinD, Create KinD cluster and Install kustomize + run: ./tests/gh-actions/install_KinD_create_KinD_cluster_install_kustomize.sh - name: Install kubectl run: ./tests/gh-actions/install_kubectl.sh From 087c0172658bab4d755c7b08b841fb3f36329a5b Mon Sep 17 00:00:00 2001 From: hansinikarunarathne Date: Thu, 15 Aug 2024 00:37:58 +0530 Subject: [PATCH 28/28] change time pot time Signed-off-by: hansinikarunarathne --- .github/workflows/pipeline_run_from_notebook.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pipeline_run_from_notebook.yaml b/.github/workflows/pipeline_run_from_notebook.yaml index a73b19077..d11c6879f 100644 --- a/.github/workflows/pipeline_run_from_notebook.yaml +++ b/.github/workflows/pipeline_run_from_notebook.yaml @@ -61,7 +61,7 @@ jobs: kubectl apply -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml kubectl wait --for=jsonpath='{.status.readyReplicas}'=1 \ -f tests/gh-actions/kf-objects/notebook.test.kubeflow-user-example.com.yaml \ - --timeout 3600s + --timeout 2400s - name: Wait for the kubeflow-m2m-oidc-configurator Job run: |