fix dex-login-test #2830
Merged
fix dex-login-test #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com>
tzabbi
force-pushed
the
fix-the-new-dex-test
branch
from
640ed04
to
2b3103f
Compare
tzabbi
force-pushed
the
fix-the-new-dex-test
branch
2 times, most recently
from
5e1d53a
to
4d88e64
Compare
|
@juliusvonkohout do you now what has to be deployt that we can log into the central dashboard? |
tzabbi
force-pushed
the
fix-the-new-dex-test
branch
from
a310fba
to
2b3103f
Compare
tzabbi
force-pushed
the
fix-the-new-dex-test
branch
from
af7f220
to
2b3103f
Compare
…ogin Signed-off-by: Tom Zaspel <tom@zaspel.it>
Signed-off-by: Tom Zaspel <tom@zaspel.it>
Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com>
|
You might want to take a look at https://github.com/kubeflow/manifests/blob/master/.github/workflows/notebook_controller_m2m_test.yaml and other files there for reference |
|
#2805 is also worth a look |
|
But what you have looks also good. We have to anyway restructure our tests in #2805 and other PRs |
|
Ready for review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 815815a
into
kubeflow:fix-the-new-dex-test
6 of 7 checks passed
juliusvonkohout
pushed a commit
that referenced
this pull request
Aug 21, 2024
* fix dex-login-test: - set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> * Add all required componentes which have to be installed to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add kustomizeation file to deploy all required stuff to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add statuscode response in dex login Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> --------- Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it>
juliusvonkohout
pushed a commit
that referenced
this pull request
Aug 21, 2024
* fix dex-login-test: - set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> * Add all required componentes which have to be installed to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add kustomizeation file to deploy all required stuff to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add statuscode response in dex login Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> --------- Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Aug 25, 2024
* renable more parts of the dex test Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix dex-login-test (#2830) * fix dex-login-test: - set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> * Add all required componentes which have to be installed to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add kustomizeation file to deploy all required stuff to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add statuscode response in dex login Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> --------- Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> Co-authored-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com>
hansinikarunarathne
pushed a commit
to hansinikarunarathne/kubeflow-manifests
that referenced
this pull request
Aug 26, 2024
* renable more parts of the dex test Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix dex-login-test (kubeflow#2830) * fix dex-login-test: - set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> * Add all required componentes which have to be installed to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add kustomizeation file to deploy all required stuff to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add statuscode response in dex login Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> --------- Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> Co-authored-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com>
hansinikarunarathne
pushed a commit
to hansinikarunarathne/kubeflow-manifests
that referenced
this pull request
Aug 26, 2024
* renable more parts of the dex test Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix dex-login-test (kubeflow#2830) * fix dex-login-test: - set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> * Add all required componentes which have to be installed to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add kustomizeation file to deploy all required stuff to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add statuscode response in dex login Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> --------- Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> Co-authored-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
pschoen-itsc
pushed a commit
to pschoen-itsc/kf-manifests
that referenced
this pull request
Sep 3, 2024
* renable more parts of the dex test Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * fix dex-login-test (kubeflow#2830) * fix dex-login-test: - set executable permission for python script - set shebang line in python script Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> * Add all required componentes which have to be installed to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add kustomizeation file to deploy all required stuff to test dex login Signed-off-by: Tom Zaspel <tom@zaspel.it> * Add statuscode response in dex login Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> --------- Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Tom Zaspel <tom@zaspel.it> Co-authored-by: Tom Zaspel <40226087+tzabbi@users.noreply.github.com> Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
📦 List any dependencies that are required for this change
🐛 If this PR is related to an issue, please put the link to the issue here.
✅ Contributor checklist
DCOcheck)cla/googlecheck)