Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added securityContext profiles for deployments failing PSS restricted level #2836

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

biswajit-9776
Copy link
Contributor

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I added securityContext for profile-controller containers kfam and manager.

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@biswajit-9776
Copy link
Contributor Author

Will be adding more to the patches and will rename them after the warnings I get locally vanish out.

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Aug 9, 2024
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@biswajit-9776 biswajit-9776 changed the title Added securityContext for profile-controller deployments Added securityContext profiles for deployments failing PSS restricted level Aug 11, 2024
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@juliusvonkohout juliusvonkohout linked an issue Aug 12, 2024 that may be closed by this pull request
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Aug 15, 2024
@biswajit-9776
Copy link
Contributor Author

/retest

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
@biswajit-9776
Copy link
Contributor Author

@juliusvonkohout, I have undone the changes to the cronjob, the patches for pipelines, profile controller and other deployments of static namespaces are here. Do let me know if you need anything else before merging.

@juliusvonkohout
Copy link
Member

For the cronjob you need to work together with hansini

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 49d2c9c into kubeflow:master Aug 16, 2024
6 checks passed
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
… level (kubeflow#2836)

* Added securityContext for profile-controller deployments

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Fixed PSS warnings for containers kfam and manager

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Added securitycontext profiles to dex and oauth2-proxy deployments

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Added seccompProfile for cluster-local-gateway

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Added securityContext to cronjob

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Added securityContext to pipelines pods

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* trigger GitHub actions

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* trigger GitHub actions

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

* Undoing changes to cronjob

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>

---------

Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rootless Kubeflow
2 participants