Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Kubeflow Manifest tests #2861

Conversation

hansinikarunarathne
Copy link
Member

… made a triiger path

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed ...

🐛 If this PR is related to an issue, please put the link to the issue here.

#2797

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

… made a triiger path

Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
@juliusvonkohout
Copy link
Member

Please check all trigger paths in all files whether they are still valid.

@juliusvonkohout
Copy link
Member

/lgtm
/approve

Please check all trigger paths in all files whether they are still valid in a follow up PR.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit afc358d into kubeflow:master Aug 28, 2024
9 checks passed
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
Signed-off-by: hansinikarunarathne <hansini.20@cse.mrt.ac.lk>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants