Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PR template #2863

Merged

Conversation

tarilabs
Copy link
Member

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

follow-up to #2793

  • add link to sign-off/DCO (I found this link helpful to share with contributors while explain it/answering the newcomer the question about DCO)
  • CLA is no longer required

📦 List any dependencies that are required for this change

none

🐛 If this PR is related to an issue, please put the link to the issue here.

none

✅ Contributor checklist

  • Make sure you have tested with kustomize. See Installation Prerequisites
  • All the commits have been signed-off (To pass the DCO check)

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

wdyt?

follow-up to kubeflow#2793
- add link to sign-off/DCO
- CLA no longer required

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: tarilabs <matteo.mortari@gmail.com>
@tarilabs
Copy link
Member Author

i've updated 65b5722 with a link to KF community about DCO which I found this morning :)

@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit df2c0a6 into kubeflow:master Aug 28, 2024
6 checks passed
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
* update PR template

follow-up to kubeflow#2793
- add link to sign-off/DCO
- CLA no longer required

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

* update DCO link to one in KF community

Signed-off-by: tarilabs <matteo.mortari@gmail.com>

---------

Signed-off-by: tarilabs <matteo.mortari@gmail.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants