-
Notifications
You must be signed in to change notification settings - Fork 869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugging warnings in pss workflow #2866
Merged
Merged
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
7ab6e55
Debugging warnings in pss workflow
biswajit-9776 0f00b27
Shifted order of applying patches to workflow
biswajit-9776 a3fd0ed
Fixed linting
biswajit-9776 b239d2a
Increased timeout
biswajit-9776 13f5972
Skip patching dynamic namespaces
biswajit-9776 66f6493
Remove debugging job
biswajit-9776 e8829c3
Debugging by restarting deployments
biswajit-9776 b22ced2
Removed redundant line from patch
biswajit-9776 ab29ecf
Replace restart with wait command
biswajit-9776 39bd95b
Replace wait for all command with individual wait command
biswajit-9776 5f0741a
Added wait command for pods in kubeflow namespace
biswajit-9776 cbed790
Fixed linting
biswajit-9776 e00b5da
Separated wait commands for separate namespaces
biswajit-9776 519fef4
Increased timeout to 600s
biswajit-9776 928ffb9
Added wait commands in loop
biswajit-9776 b504f36
Fixed typo
biswajit-9776 363113c
Debugging failing wait commands
biswajit-9776 63821aa
Added log process in background
biswajit-9776 c3a7798
Fixed type
biswajit-9776 262c78c
Fixed typo
biswajit-9776 9a21438
Added describe command
biswajit-9776 86c9577
Added runAsUser to debug
biswajit-9776 3db6583
Added UID 1000 to all pods
biswajit-9776 74eb10e
Added single wait command
biswajit-9776 9ace6ac
Debugging
biswajit-9776 005500c
Removed background process
biswajit-9776 77f400a
Increased timeout
biswajit-9776 6f9d201
Retesting
biswajit-9776 241f948
Removed UID from profile controller
biswajit-9776 a564ded
Debugging profiles-controller
biswajit-9776 3de18f4
Increased timeout for profiles-controller
biswajit-9776 b7dd0bf
Pausing patch to profile-controller
biswajit-9776 c5ccd37
Fixed indentation
biswajit-9776 94a351f
Fixed error
biswajit-9776 17a35c4
Fixed error
biswajit-9776 7f521f2
Fixed error
biswajit-9776 04fb9a7
Debugging cache-server
biswajit-9776 09e0c84
Debugging cache-server
biswajit-9776 7492290
Increased timeout for cache-server
biswajit-9776 bd13b6d
Debugging
biswajit-9776 5cc7aa6
Deleting pods exclusively
biswajit-9776 43f6b3b
Added GID
biswajit-9776 a495be7
Debugging cache-server
biswajit-9776 f496072
Sleeping for 300s
biswajit-9776 523febc
Updated GID to 1000
biswajit-9776 cdbea53
Added GID to all pods
biswajit-9776 cb04ee9
Checking pods securityContext
biswajit-9776 8448450
Debugging
biswajit-9776 233dc59
Debugging without IDs
biswajit-9776 4bbbdeb
Debugging
biswajit-9776 9d8d641
Debugging
biswajit-9776 f31179a
Debugging
biswajit-9776 c4693b1
Added GID
biswajit-9776 d9b6250
Debugging
biswajit-9776 5a2f711
Debugging
biswajit-9776 c59a8f8
Debugging
biswajit-9776 8754c92
Debugging
biswajit-9776 5e8fd14
Debugging
biswajit-9776 10a23ae
Debugging
biswajit-9776 bce60a3
Debugging
biswajit-9776 9b95dc6
Debugging
biswajit-9776 a713a4c
Debugging
biswajit-9776 bb20a6b
Debugging
biswajit-9776 c2af245
Debugging
biswajit-9776 d6ebc3f
Debugging
biswajit-9776 86c372c
Debugging
biswajit-9776 b88fe8f
Added wait time for istio-cni test
biswajit-9776 523f9a0
Debugging
biswajit-9776 2bd7e07
Increased timeout
biswajit-9776 d0f3cc6
Added dynamic ns to pss_test
biswajit-9776 5743a1f
Fix lint
biswajit-9776 65ec9f7
Configured istio initContainer
biswajit-9776 b00fe48
Fixed lint
biswajit-9776 0cd0454
Added seccompProfile attribute for istio-proxy
biswajit-9776 0cd2870
Adding PSS label to dynamic ns
biswajit-9776 f3cace5
Reordered dynamic ns test
biswajit-9776 2cb79fb
Commented the dynamic ns tests
biswajit-9776 5ed56cf
Fix lint
biswajit-9776 e40311f
Removing debugging stuffs
biswajit-9776 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
apiVersion: apps/v1 | ||
kind: StatefulSet | ||
metadata: | ||
name: metacontroller | ||
namespace: kubeflow | ||
spec: | ||
template: | ||
spec: | ||
containers: | ||
- name: metacontroller | ||
securityContext: | ||
seccompProfile: | ||
type: RuntimeDefault |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,6 @@ metadata: | |
name: oauth2-proxy | ||
namespace: oauth2-proxy | ||
spec: | ||
replicas: 2 | ||
template: | ||
spec: | ||
containers: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
apiVersion: apps/v1 | ||
kind: Deployment | ||
metadata: | ||
name: workflow-controller | ||
namespace: kubeflow | ||
spec: | ||
template: | ||
spec: | ||
containers: | ||
- name: workflow-controller | ||
securityContext: | ||
seccompProfile: | ||
type: RuntimeDefault | ||
runAsNonRoot: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good :-) according to the workflow results it seems to work, but please verify it manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did run it manually and opened up the configmap to observe the changes in place as we want. Also, I have removed the comments which I can later add as commits for dynamic namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ml-pipeline pod in my local system does seem to fail with CrashLoopBackOff as I open it up. Maybe I need to increase my fs.inotify.max_user_{instances, watches} .