Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/expand spark rbac #2893

Closed

Conversation

GezimSejdiu
Copy link
Contributor

Description

This PR expands the existing Spark RBAC (Role-Based Access Control) to include support for ScheduledSparkApplication resources. Previously, the RBAC configuration only covered SparkApplication resources, which limited the ability to manage scheduled jobs effectively.

Changes Made

  • Added necessary RBAC rules for ScheduledSparkApplication resources, including permissions for get, list, watch, create, update, delete, and patch.
  • Updated existing ClusterRole and Role bindings to ensure scheduled Spark jobs have appropriate access.

Why This is Needed

The absence of RBAC permissions for ScheduledSparkApplication resulted in failed scheduled job executions, as the service account lacked the required permissions. By extending the RBAC, we ensure that scheduled Spark jobs are managed securely and can operate without interruptions.

GezimSejdiu and others added 23 commits October 11, 2024 14:43
- Add Spark operator manifests for distributed Spark workloads.
- Ensure integration with Kubeflow pipelines for seamless Spark job execution.

Signed-off-by: Gezim Sejdiu <g.sejdiu@gmail.com>
Signed-off-by: Gezim Sejdiu <g.sejdiu@gmail.com>
Fix some issues with tests,

Signed-off-by: Gezim Sejdiu <g.sejdiu@gmail.com>
Signed-off-by: Gezim Sejdiu <g.sejdiu@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
…ebhook

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Gezim Sejdiu <g.sejdiu@gmail.com>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout
Copy link
Member

Please rebase to master first and start with a fresh branch.

@GezimSejdiu
Copy link
Contributor Author

Please rebase to master first and start with a fresh branch.

Right. I did fetch upstream. Let me rebase it.

@GezimSejdiu
Copy link
Contributor Author

I'm closing as I forgot to rebase upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants