Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand spark rbac to include scheduledsparkapplication #2894

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

GezimSejdiu
Copy link
Contributor

Description

This PR expands the existing Spark RBAC (Role-Based Access Control) to include support for ScheduledSparkApplication resources. Previously, the RBAC configuration only covered SparkApplication resources, which limited the ability to manage scheduled jobs effectively.

Changes Made

  • Added necessary RBAC rules for ScheduledSparkApplication resources, including permissions for get, list, watch, create, update, delete, and patch.
  • Updated existing ClusterRole and Role bindings to ensure scheduled Spark jobs have appropriate access.

Why This is Needed

The absence of RBAC permissions for ScheduledSparkApplication resulted in failed scheduled job executions, as the service account lacked the required permissions. By extending the RBAC, we ensure that scheduled Spark jobs are managed securely and can operate without interruptions.

Signed-off-by: Gezim Sejdiu <g.sejdiu@gmail.com>
@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f9cff8b into kubeflow:master Oct 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants