Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Readme file to fix Kustomize links and Tekton pipelines information #2906

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

varodrig
Copy link
Contributor

@varodrig varodrig commented Nov 4, 2024

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

updated README FILE to:

  • update kustomize link
  • remove kubeflow tekton pipelines from table

🐛 If this PR is related to an issue, please put the link to the issue here.

Resolves issue #2902)

✅ Contributor checklist

Signed-off-by: varodrig <varodrig@redhat.com>
@varodrig varodrig changed the title update kustomize link and remove kubeflow tekton pipelines from table update Readme file to fix Kustomize links and Tekton pipelines information Nov 4, 2024
@varodrig varodrig marked this pull request as ready for review November 4, 2024 03:55
@varodrig
Copy link
Contributor Author

varodrig commented Nov 4, 2024

@juliusvonkohout can you review? thanks.

@juliusvonkohout juliusvonkohout linked an issue Nov 4, 2024 that may be closed by this pull request
7 tasks
@juliusvonkohout
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 51b9638 into kubeflow:master Nov 4, 2024
6 checks passed
juliusvonkohout pushed a commit to tarekabouzeid/manifests that referenced this pull request Nov 4, 2024
…ation (kubeflow#2906)

Signed-off-by: varodrig <varodrig@redhat.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
google-oss-prow bot pushed a commit that referenced this pull request Nov 4, 2024
* Upgrade istio-cni to v.1.23.2

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>

* update Readme file to fix Kustomize links and Tekton pipelines information (#2906)

Signed-off-by: varodrig <varodrig@redhat.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade istio to v.1.23.2 (#2890)

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>

---------

Signed-off-by: Tarek Abouzeid <tarek.abouzeid@teliacompany.com>
Signed-off-by: varodrig <varodrig@redhat.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Co-authored-by: Valentina Rodriguez Sosa <64439402+varodrig@users.noreply.github.com>
@varodrig varodrig deleted the link-update branch November 4, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation issue - link to the best practices is not working
2 participants