feat(ws): initial commit for frontend #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederign
force-pushed
the
notebooks-v2
branch
2 times, most recently
from
8457744
to
87b632e
Compare
jiridanek
reviewed
Jun 21, 2024
.github/workflows/ui-bff-build.yml
Outdated
Comment on lines
17
to
20
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.22.2' |
There was a problem hiding this comment.
If you give it explicit path to go.sum, this can fetch and cache go dependencies for you. This is IMO worth doing. And you can tell it to take go version from your go.mod, so there is a little bit less duplicated information
notebooks/.github/workflows/workspaces-controller_unit-tests.yaml
Lines 20 to 25 in 565a740
There was a problem hiding this comment.
agree! I just updated it! Thanks for the tip!
In this PR: - UI frontend scaffolding - Github Action for frontend and backend Most of the content of this PR is extract from https://github.com/patternfly/patternfly-react-seed/tree/v6. Thank you so much patternfly team for the seed! Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
thesuperzapper
requested review from
thesuperzapper
and removed request for
jiridanek,
andreyvelich and
zijianjoy
thesuperzapper
changed the title
thesuperzapper
requested changes
Jun 28, 2024
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
thesuperzapper
approved these changes
Jun 28, 2024
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
|
@ederign thanks for this, lets merge to keep wroking on the first features /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 29, 2024
* feat: client ui frontend scaffolding In this PR: - UI frontend scaffolding - Github Action for frontend and backend Most of the content of this PR is extract from https://github.com/patternfly/patternfly-react-seed/tree/v6. Thank you so much patternfly team for the seed! Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> * Changes requested by code review Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> * Fixing icons Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> --------- Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 29, 2024
* feat: client ui frontend scaffolding In this PR: - UI frontend scaffolding - Github Action for frontend and backend Most of the content of this PR is extract from https://github.com/patternfly/patternfly-react-seed/tree/v6. Thank you so much patternfly team for the seed! Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> * Changes requested by code review Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> * Fixing icons Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> --------- Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 29, 2024
* feat: client ui frontend scaffolding In this PR: - UI frontend scaffolding - Github Action for frontend and backend Most of the content of this PR is extract from https://github.com/patternfly/patternfly-react-seed/tree/v6. Thank you so much patternfly team for the seed! Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> * Changes requested by code review Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> * Fixing icons Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com> --------- Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Description
Next week, we plan to start adding features to our frontend, so I've created a scaffolding PR with a basic project structure to avoid mixing it with feature development.
How Has This Been Tested?
Run local dev mode and prod builds.