Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ws): add safety prompt for E2E test execution #28

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

Adembc
Copy link

@Adembc Adembc commented Jul 23, 2024

This PR enhances the safety of running make test-e2e by implementing a confirmation prompt.

Why is this important?

The make test-e2e command executes tests on the current Kubernetes cluster. This can potentially disrupt a production environment, as the tests include cleanup operations such as deleting cert-manager after completion.

What changes were made?

  1. Added a confirmation prompt before test execution:

    • Displays the current Kubernetes cluster context
    • Asks for user confirmation to proceed
  2. Implemented a bypass option for CI/CD pipelines:

    • Set environment variable KUBEFLOW_TEST_PROMPT=FALSE to skip the prompt
    • The variable is case-insensitive (e.g., "FALSE", "false", or "False" are all valid)
  3. User confirmation:

    • Accepts "yes" or "y" (case-insensitive) to proceed with the tests
    • Any other input will abort the operation

Signed-off-by: Adem Baccara <71262172+Adembc@users.noreply.github.com>
@thesuperzapper thesuperzapper added project/notebooks-v2 project - kubeflow notebooks v2 area/ci area - related to ci labels Aug 1, 2024
@thesuperzapper thesuperzapper added this to the v2.0.0-alpha.0 milestone Aug 1, 2024
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for this @Adembc!

I have made wordings changes in f6b092b and it should be good to go now.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 5, 2024
@google-oss-prow google-oss-prow bot merged commit 50fda65 into kubeflow:notebooks-v2 Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ci area - related to ci lgtm project/notebooks-v2 project - kubeflow notebooks v2 size/S
Projects
Development

Successfully merging this pull request may close these issues.

2 participants