Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): Notebooks 2.0 // Backend // List Workspaces API and use controller-runtime for backend #44

Closed
wants to merge 8 commits into from

Conversation

ederign
Copy link
Member

@ederign ederign commented Sep 14, 2024

curl -i localhost:4000/api/v1/spawner/workspace-test/workspaces

{
  "workspaces": [
    {
      "name": "jupyterlab-workspace-1",
      "kind": "jupyterlab",
      "image": "jupyterlab_scipy_190",
      "config": "tiny_cpu",
      "status": "Running",
      "home_volume": "workspace-home-pvc",
      "data_volume": "/data/my-data",
      "last_activity": "1969-12-31 19:00:00 EST"
    },
    {
      "name": "jupyterlab-workspace-2",
      "kind": "jupyterlab",
      "image": "jupyterlab_scipy_190",
      "config": "tiny_cpu",
      "status": "Running",
      "home_volume": "workspace-home-pvc",
      "data_volume": "/data/my-data",
      "last_activity": "1969-12-31 19:00:00 EST"
    }
  ]
}

Other than that, this PR makes the following changes on top of the referenced PR:

  1. Fixes healthcheck handler and it's tests;
  2. Create workspace_handler and it's tests
  3. Add go mock for testing
  4. Create WorkspaceModel BFF type
  5. Create Workspace model and GetWorkspaces method
  6. mock_workspaces_data.go was generated with ~/go/bin/mockgen -destination=test/mock_client.go -package=mocks sigs.k8s.io/controller-runtime/pkg/client Client

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ederign and others added 8 commits September 14, 2024 15:24
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants