Skip to content

Commit

Permalink
remove duplicate emissary call in executor
Browse files Browse the repository at this point in the history
As per the initial inline dev comment, argo podspecpatch did not add the
emissary call, and had to be manualy added. This was fixed a couple of
argo versions back. However, as a result executor pod makes double calls
to the executor, which as a consequence also results in superflous logs.

This change removes the additional call to emissary to resolve this.

Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
  • Loading branch information
HumairAK committed Sep 5, 2024
1 parent 87db4c9 commit c8328bf
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions backend/src/v2/driver/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,6 @@ func initPodSpecPatch(
userCmdArgs = append(userCmdArgs, container.Command...)
userCmdArgs = append(userCmdArgs, container.Args...)
launcherCmd := []string{
// TODO(Bobgy): workaround argo emissary executor bug, after we upgrade to an argo version with the bug fix, we can remove the following line.
// Reference: https://github.com/argoproj/argo-workflows/issues/7406
"/var/run/argo/argoexec", "emissary", "--",
component.KFPLauncherPath,
// TODO(Bobgy): no need to pass pipeline_name and run_id, these info can be fetched via pipeline context and pipeline run context which have been created by root DAG driver.
"--pipeline_name", pipelineName,
Expand Down

0 comments on commit c8328bf

Please sign in to comment.