Skip to content

Commit

Permalink
Kubeflow Pipelines V2 integration Testes
Browse files Browse the repository at this point in the history
Signed-off-by: Diego Lovison <diegolovison@gmail.com>
  • Loading branch information
diegolovison committed Aug 21, 2024
1 parent 1a07ffa commit f6cffd5
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 39 deletions.
38 changes: 38 additions & 0 deletions .github/workflows/kubeflow-pipelines-integration-v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Kubeflow Pipelines V2 integration Tests

on:
push:
branches:
- master
pull_request:
paths:
- '.github/workflows/kubeflow-pipelines-integration-v2.yml'
- 'samples'
- 'core'
- 'backend'

jobs:
integration-tests:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.8]

steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python }}

- name: Create KFP cluster
uses: ./.github/actions/kfp-cluster

- name: Forward API port
run: ./scripts/deploy/github/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888

- name: Run the Integration Tests
run: |
./backend/src/v2/test/integration-test.sh
14 changes: 2 additions & 12 deletions backend/src/v2/test/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,9 @@ include $(ENV_PATH)
SHELL = /bin/bash

.PHONY: integration-test
integration-test: upload
integration-test:
export KF_PIPELINES_ENDPOINT=$(HOST) \
&& python -u sample_test.py \
--samples_config samples/test/config-integration.yaml \
--timeout_mins 60 \
--context $(GCS_ROOT)/src/context.tar.gz \
--gcs_root $(GCS_ROOT)/data \
--gcr_root $(GCR_ROOT) \
--kfp_package_path "$(KFP_PACKAGE_PATH)"

.PHONY: upload
upload: context
python -u scripts/upload_gcs_blob.py tmp/context.tar.gz $(GCS_ROOT)/src/context.tar.gz
&& python -u ../../../../samples/v2/sample_test.py

.PHONY: context
context:
Expand Down
6 changes: 0 additions & 6 deletions backend/src/v2/test/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
# install kfp sdk from local path
-e ../../../../sdk/python
# TODO(chensun): remove the deprecated dependencies once migrated tests.
-r ../../../../sdk/python/requirements-deprecated.txt
ml-metadata==1.14.0
minio==7.0.4
google-cloud-storage
fire
-e ../../../../samples/test/utils
20 changes: 0 additions & 20 deletions backend/src/v2/test/scripts/upload_gcs_blob.py

This file was deleted.

2 changes: 1 addition & 1 deletion samples/v2/sample_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def run_test_case(self, pipeline_func: GraphComponent, timeout: int):
print("Run details page URL:")
print(f"{self._kfp_ui_and_port}/#/runs/details/{run_response.run_id}")

self.assertEqual(run_response.state, "SUCCEEDED")
self.assertEqual(run_response.state, "SUCCEEDED x")


if __name__ == '__main__':
Expand Down

0 comments on commit f6cffd5

Please sign in to comment.